Extract l10n-related parts of NetworkScreenHandler to a helper file

Extract l10n-related parts of NetworkScreenHandler to a helper file

This CL extracts the GetLanguageList(), GetAcceptLanguageList and
GetLoginKeyboardLayouts() methods from NetworkScreenHandler to a helper
file. The methods will be reused by SigninScreenHandler to implement a
language and keyboard layout picker for public session pods.

BUG=214904, 241790
TEST=Updated and extended unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284683

[bartfab (slow), 2014-07-15 18:03:11]

Hi Nikita,

Could you take a look please?

[Alexander Alekseev, 2014-07-16 19:12:05]

On 2014/07/15 18:03:11, bartfab wrote:
> Hi Nikita,
> 
> Could you take a look please?

This CL has merge conflict with https://codereview.chromium.org/389913002/ .
It would not affect the functionality, but IME initialization would be a bit
different.

[Nikita (slow), 2014-07-17 06:14:54]

https://codereview.chromium.org/397723002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
(right):

https://codereview.chromium.org/397723002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h:71:
static base::ListValue* GetUILanguageList(
How about moving GetUILanguageList/GetLanguageListInternal out of
CrosLanguageOptionsHandler to the l10n_util.h.

This will minimize its dependencies on src/chrome and potentially can be moved
later out of src/chrome if needed.

[bartfab (slow), 2014-07-21 14:28:30]

https://codereview.chromium.org/397723002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
(right):

https://codereview.chromium.org/397723002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h:71:
static base::ListValue* GetUILanguageList(
On 2014/07/17 06:14:54, Nikita Kostylev wrote:
> How about moving GetUILanguageList/GetLanguageListInternal out of
> CrosLanguageOptionsHandler to the l10n_util.h.
> 
> This will minimize its dependencies on src/chrome and potentially can be moved
> later out of src/chrome if needed.

Done.

[Nikita (slow), 2014-07-21 15:24:52]

lgtm, thanks

Alexander will take a closer look.

[Alexander Alekseev, 2014-07-21 19:37:41]

lgtm

[bartfab (slow), 2014-07-21 19:39:58]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-07-21 19:42:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/397723002/60001

[commit-bot: I haz the power, 2014-07-21 23:47:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 00:00:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 00:00:51]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[bartfab (slow), 2014-07-22 10:04:51]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:06:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/397723002/80001

[commit-bot: I haz the power, 2014-07-22 11:48:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[bartfab (slow), 2014-07-22 11:59:49]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-07-22 12:01:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/397723002/100001

[commit-bot: I haz the power, 2014-07-22 15:53:38]

Change committed as 284683