Provide an option to launch the date and time preferences.

Provide an option to launch the date and time preferences.

When an X.509 certificate appears invalid because it is expired or not yet 
valid, but we have reason to believe the clock is wrong, help users find out 
how to fix their clock.

A future CL will run a check for the time at startup (and periodically
after?) and raise an infobar with similar functionality, as well.

BUG=349653
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284638

[palmer, 2014-07-16 00:39:13]

jorgelo: Can you clue me in on how to launch ChromeOS's date and time settings?

rsesek: ...iOS?

felt: LGTY as a first pass (infobar to come)?

[Jorge Lucangeli Obes, 2014-07-16 00:42:53]

Open new tab/window and navigate to 'chrome://settings/search#Date%20and%20time'
I believe.

+stevenjb who might have a better suggestion.

[stevenjb, 2014-07-16 01:11:33]

+ michaelpg who has worked on both system clock and settings code in Chrome OS.

The method you want to correctly open a settings subpage is
chrome::ShowSettingsSubPageForProfile(), in chrome_pages.cc. 

The suggested subpage is correct, see 
SystemTrayDelegateChromeOS::ShowDateSettings() for how to build that correctly.

https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
chrome/browser/ssl/ssl_blocking_page.cc:620: #elif defined(OS_CHROMEOS)
Puttung all of these #ifdefs inside a case block is really hard to read, can we
move this logic to a helper method at least?

[michaelpg, 2014-07-16 01:24:24]

On 2014/07/16 01:11:33, stevenjb wrote:
> + michaelpg who has worked on both system clock and settings code in Chrome
OS.
> 
> The method you want to correctly open a settings subpage is
> chrome::ShowSettingsSubPageForProfile(), in chrome_pages.cc. 
> 
> The suggested subpage is correct, see 
> SystemTrayDelegateChromeOS::ShowDateSettings() for how to build that
correctly.
> 
>
https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
> File chrome/browser/ssl/ssl_blocking_page.cc (right):
> 
>
https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
> chrome/browser/ssl/ssl_blocking_page.cc:620: #elif defined(OS_CHROMEOS)
> Puttung all of these #ifdefs inside a case block is really hard to read, can
we
> move this logic to a helper method at least?

You can launch the SetTimeDialog on its own, without navigating to the Settings
page. See system_tray_delegate_chromeos.cc and date_time_options_handler.cc for
examples of this.

There is a quirk, though. The SetTimeUI only shows the timezone dropdown if the
user is not logged in. This is because, currently, the only way to open the
dialog when you are logged in is from the Settings page, where we already have
the timezone dropdown. If you want to show this dialog when the user is logged
in, and the timezone factors into certificate checks, you may want to change
this behavior. For example, update SetTimeUI to take a parameter for which
fields to show.

[palmer, 2014-07-16 02:14:35]

https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/397713007/diff/1/chrome/browser/ssl/ssl_block...
chrome/browser/ssl/ssl_blocking_page.cc:620: #elif defined(OS_CHROMEOS)
On 2014/07/16 01:11:32, stevenjb wrote:
> Puttung all of these #ifdefs inside a case block is really hard to read, can
we
> move this logic to a helper method at least?

Done.

[Robert Sesek, 2014-07-16 13:52:52]

Mac LG, though I do not think we can implement this on iOS.

https://codereview.chromium.org/397713007/diff/40001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/397713007/diff/40001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:264: base::LaunchOptions options;
You may need to set allow_new_privs = true on Linux.

[palmer, 2014-07-17 21:59:39]

+agl for OWNERS review.

[felt, 2014-07-17 22:26:08]

lgtm fwiw

https://codereview.chromium.org/397713007/diff/80001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/397713007/diff/80001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:288: VLOG(1) << "Running " <<
command.GetCommandLineString();
was this VLOG for testing or meant to stay?

[palmer, 2014-07-18 01:23:21]

https://codereview.chromium.org/397713007/diff/80001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/397713007/diff/80001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:288: VLOG(1) << "Running " <<
command.GetCommandLineString();
> was this VLOG for testing or meant to stay?

I'll whack it, it isn't necessary.

[palmer, 2014-07-18 02:15:53]

Oops, I forgot to actually add agl as a reviewer (for OWNERS review).

[agl, 2014-07-18 02:18:51]

lgtm

[palmer, 2014-07-18 02:25:06]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-07-18 02:27:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/397713007/120001

[commit-bot: I haz the power, 2014-07-18 06:21:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-18 06:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 06:24:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[palmer, 2014-07-18 23:26:31]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:27:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/397713007/160001

[commit-bot: I haz the power, 2014-07-19 03:02:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-19 03:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 03:21:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[felt, 2014-07-19 03:29:07]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-07-19 03:30:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/397713007/160001

[commit-bot: I haz the power, 2014-07-19 04:52:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-19 05:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 05:03:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[palmer, 2014-07-21 22:39:08]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-07-21 22:41:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/397713007/180001

[commit-bot: I haz the power, 2014-07-22 02:52:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 06:46:46]

Change committed as 284638