Ensure pdf plugin sends DidStartLoading() consistently

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 331 matching lines @@
 
   if (!url)
     return false;
 
   CreatePageIndicator(IsPrintPreviewUrl(url));
 
   if (!full_) {
     // For PDFs embedded in a frame, we don't get the data automatically like we
     // do for full-frame loads.  Start loading the data manually.
     LoadUrl(url);
+  } else {
+    DCHECK(!did_call_start_loading_);

[Vitaly Buka (NO REVIEWS), 2014/07/16 18:32:45]

Maybe CHECK() to make crash in release, so we could see reports

+    pp::PDF::DidStartLoading(this);
+    did_call_start_loading_ = true;

[jam, 2014/07/16 21:25:43]

I'm a bit confused, I tried doing window.print() (per the code being edited in
the other file). I hit line 348 twice in the renderer for print preview, but
both times the full_ was false. how is this else statement being reached?

   }
 
   ZoomLimitsChanged(kMinZoom, kMaxZoom);
 
   text_input_.reset(new pp::TextInput_Dev(this));
 
   url_ = url;
   return engine_->New(url);
 }
 
@@ skipping 2342 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf