Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp - Issue 397713004: Overlay scrollbars must respect ancestor clip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp

Issue 397713004: Overlay scrollbars must respect ancestor clip (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: . Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/compositing/CompositedLayerMapping.cpp ('K') | « Source/core/rendering/compositing/CompositedLayerMapping.cpp ('k') | Source/core/rendering/compositing/GraphicsLayerUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp

diff --git a/Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp b/Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp

index 79bbfaa2cff5126d5124bfed8affce39b7dcd58d..47d017ed66891a42a03aa8e519b67b5eb2e2730d 100644

--- a/Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp

+++ b/Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp

@@ -126,8 +126,7 @@ void GraphicsLayerTreeBuilder::rebuild(RenderLayer& layer, AncestorInfo info)

}

if (layer.scrollParent()

- && layer.scrollParent()->hasCompositedLayerMapping()

- && layer.scrollParent()->scrollableArea()->hasOverlayScrollbars()

+ && layer.scrollParent()->needsToReparentOverflowControls()

&& layer.scrollParent()->scrollableArea()->topmostScrollChild() == &layer)

info.childLayersOfEnclosingCompositedLayer->append(layer.scrollParent()->compositedLayerMapping()->detachLayerForOverflowControls(*info.enclosingCompositedLayer));

}