Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 397673002: ui/gfx: optimize RGBA to RGB conversion by using memcpy in png_codec.cc (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: optimize RGBA to RGB conversion by using memcpy in png_codec.cc BUG=none TEST=gfx_unittests --gtest_filter="PNGCodec*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M ui/gfx/codec/png_codec.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
hyunki
Please take a look. Thanks. :)
6 years, 5 months ago (2014-07-15 14:44:35 UTC) #1
hyunki
Sorry. I've updated the reviewers.
6 years, 5 months ago (2014-07-15 14:55:02 UTC) #2
Lei Zhang
lgtm, but you need a ui/ OWNER to review.
6 years, 5 months ago (2014-07-15 17:22:48 UTC) #3
hyunki
Ping. PTAL. Thank you.
6 years, 5 months ago (2014-07-15 18:26:05 UTC) #4
sky
LGTM
6 years, 5 months ago (2014-07-15 20:37:44 UTC) #5
sky
LGTM
6 years, 5 months ago (2014-07-15 20:39:12 UTC) #6
hyunki
Thanks for the review.
6 years, 5 months ago (2014-07-15 21:13:00 UTC) #7
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-15 21:13:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/397673002/1
6 years, 5 months ago (2014-07-15 21:16:57 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 05:22:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 05:43:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171092)
6 years, 5 months ago (2014-07-16 05:43:26 UTC) #12
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-16 05:53:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/397673002/1
6 years, 5 months ago (2014-07-16 05:58:21 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 06:23:01 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 07:33:36 UTC) #16
Message was sent while issue was closed.
Change committed as 283385

Powered by Google App Engine
This is Rietveld 408576698