Issue 397613002: Remove failure tag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397613002: Remove failure tag. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)

Modified:
6 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove failure tag. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22408

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -24 lines)			Patch
	M	src/globals.h	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
	M	src/spaces.h	View		2 chunks	+3 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/397613002/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/397613002/diff/1/src/globals.h#newcode218 src/globals.h:218: nit: Let's keep two empty newlines.

6 years, 5 months ago (2014-07-15 11:05:33 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/397613002/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/397613002/diff/1/src/globals.h#newcode218 src/globals.h:218: On 2014/07/15 11:05:33, Michael Starzinger wrote: > nit: Let's ...

6 years, 5 months ago (2014-07-15 11:10:53 UTC) #3

Hannes Payer (out of office)

6 years, 5 months ago (2014-07-15 11:10:53 UTC) #4

Hannes Payer (out of office)

6 years, 5 months ago (2014-07-15 11:12:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22408 (presubmit successful).

Expand Messages | Collapse Messages

Issue 397613002: Remove failure tag. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages