Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 397593008: Keep new arrays allocated with 'new Array(N)' in fast mode (Closed)

Created:
6 years, 5 months ago by danno
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Keep new arrays allocated with 'new Array(N)' in fast mode Also explicit length setting with a.length = N should remain in fast mode. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22595

Patch Set 1 #

Patch Set 2 : Toon's comments #

Patch Set 3 : Latest #

Patch Set 4 : Tweaks #

Patch Set 5 : Remove stray changes #

Patch Set 6 : Fix tests #

Patch Set 7 : Fix perf problem in tests #

Patch Set 8 : Fix slow test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -40 lines) Patch
M src/elements.cc View 1 2 3 4 2 chunks +5 lines, -11 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 chunks +33 lines, -6 lines 0 comments Download
M test/fuzz-natives/base.js View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/apply.js View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-splice.js View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M test/mjsunit/array-unshift.js View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/elements-kind.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/polymorph-arrays.js View 1 2 3 4 5 5 chunks +7 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-2790.js View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
PTAL
6 years, 5 months ago (2014-07-24 07:58:44 UTC) #1
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-24 09:09:13 UTC) #2
danno
PTAL at patch set six (fixes failing mozilla tests)
6 years, 5 months ago (2014-07-24 11:38:50 UTC) #3
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-24 11:43:28 UTC) #4
danno
6 years, 5 months ago (2014-07-24 12:08:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #8 manually as r22595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698