Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/binary_size/run_binary_size_analysis.py

Issue 397593007: Handle shared memory symbols better in the binarysize tool. (Closed)
Patch Set: Removed extra output in unittest. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/explain_binary_size_delta_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/run_binary_size_analysis.py
diff --git a/tools/binary_size/run_binary_size_analysis.py b/tools/binary_size/run_binary_size_analysis.py
index 68982528f8366203527bba54ef9bd680df644f9f..241fa64145276302868ba1c21c6eb88c3bd29b21 100755
--- a/tools/binary_size/run_binary_size_analysis.py
+++ b/tools/binary_size/run_binary_size_analysis.py
@@ -169,7 +169,7 @@ def MakeCompactTree(symbols, symbol_path_origin_dir):
NODE_MAX_DEPTH_KEY: 0}
seen_symbol_with_path = False
cwd = os.path.abspath(os.getcwd())
- for symbol_name, symbol_type, symbol_size, file_path in symbols:
+ for symbol_name, symbol_type, symbol_size, file_path, _address in symbols:
if 'vtable for ' in symbol_name:
symbol_type = '@' # hack to categorize these separately
@@ -231,7 +231,7 @@ def DumpCompactTree(symbols, symbol_path_origin_dir, outfile):
def MakeSourceMap(symbols):
sources = {}
- for _sym, _symbol_type, size, path in symbols:
+ for _sym, _symbol_type, size, path, _address in symbols:
key = None
if path:
key = os.path.normpath(path)
« no previous file with comments | « tools/binary_size/explain_binary_size_delta_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698