Issue 397593005: Revert of Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397593005: Revert of Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, jar (doing other things), Sigurður Ásgeirsson, karen, laforge

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA (https://codereview.chromium.org/363203002/) Reason for revert: This change didn't reduce the crash rate. https://codereview.chromium.org/371073003 will generate the crash dumps. Original issue's description: > Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA > crash rate decreases. > > BUG=391165 > R=rsesek@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281320 TBR=rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=391165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283263

Created: 6 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	components/breakpad/app/breakpad_win.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

ramant (doing other things)

Created Revert of Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA

6 years, 5 months ago (2014-07-15 22:40:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/397593005/1

6 years, 5 months ago (2014-07-15 22:42:19 UTC) #3

Message was sent while issue was closed.

Change committed as 283263