editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java - Issue 397593003: Disallow reserved words for "const Symbol(...)" with the exception of 'void'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

Issue 397593003: Disallow reserved words for "const Symbol(...)" with the exception of 'void'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase on latest svn Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java ('k') | tests/corelib/corelib.status » ('j') | tests/corelib/symbol_reserved_word_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

index 13bff77f719163bd2efdf046a828b76f02b0b45c..3959853d6b6e636513ab48a7c5bc21a1a7ccfee6 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

@@ -738,6 +738,7 @@ public class ConstantValueComputerTest extends ResolverTestCase {

assertTrue(ConstantValueComputer.isValidPublicSymbol("foo="));

assertTrue(ConstantValueComputer.isValidPublicSymbol("foo.bar="));

assertTrue(ConstantValueComputer.isValidPublicSymbol("foo.+"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("void"));

assertFalse(ConstantValueComputer.isValidPublicSymbol("_foo"));

assertFalse(ConstantValueComputer.isValidPublicSymbol("_foo.bar"));

assertFalse(ConstantValueComputer.isValidPublicSymbol("foo._bar"));

@@ -747,6 +748,8 @@ public class ConstantValueComputerTest extends ResolverTestCase {

assertFalse(ConstantValueComputer.isValidPublicSymbol("foo=.bar"));

assertFalse(ConstantValueComputer.isValidPublicSymbol("foo."));

assertFalse(ConstantValueComputer.isValidPublicSymbol("+.foo"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("void.foo"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("foo.void"));

}

private HashMap<String, DartObjectImpl> assertFieldType(HashMap<String, DartObjectImpl> fields,