Issue 397573002: X87: Clean up and update const / var

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397573002: X87: Clean up and update const / var (Closed)

Created:
6 years, 5 months ago by chunyang.dai

Modified:
6 years, 5 months ago

Reviewers:
Weiliang, Toon Verwaest

CC:
v8-dev, danno

Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: Clean up and update const / var port r22379 original commit message: This CL simplifies var / const by ensuring the behavior is consistent in itself, and with regular JS semantics; between regular var/const and eval-ed var/const. Legacy const is changed so that a declaration declares a configurable, but non-writable, slot, and the initializer reconfigures it (when possible) to non-configurable non-writable. This avoids the need for "the hole" as marker value in JSContextExtensionObjects and GlobalObjects. Undefined is used instead. BUG=

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -30 lines)			Patch
	M	src/x87/full-codegen-x87.cc	View		5 chunks	+22 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Committed as r22395

Expand Messages | Collapse Messages