Issue 397543005: Encapsulate data-format constants in EnterpriseInstallAttributes.

Issue 397543005: Encapsulate data-format constants in EnterpriseInstallAttributes. (Closed)

Created:
6 years, 5 months ago by Thiemo Nagel

Modified:
6 years, 5 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Encapsulate data-format constants in EnterpriseInstallAttributes. Also add mentioning that some constants have been copied to Chromium OS. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283772

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Julian's nit. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -79 lines)			Patch
M	chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc	View		2 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/policy/enterprise_install_attributes.h	View		3 chunks	+34 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/policy/enterprise_install_attributes.cc	View	1	3 chunks	+71 lines, -52 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Thiemo Nagel

Hi Julian, since you suggested to mention that the attribute constants have been copied to ...

6 years, 5 months ago (2014-07-16 14:52:41 UTC) #1

pastarmovj

lgtm with a nit. https://codereview.chromium.org/397543005/diff/1/chrome/browser/chromeos/policy/enterprise_install_attributes.cc File chrome/browser/chromeos/policy/enterprise_install_attributes.cc (right): https://codereview.chromium.org/397543005/diff/1/chrome/browser/chromeos/policy/enterprise_install_attributes.cc#newcode301 chrome/browser/chromeos/policy/enterprise_install_attributes.cc:301: // login_manager/device_policy_service.cc. Please add one ...

6 years, 5 months ago (2014-07-16 15:01:57 UTC) #2

Thiemo Nagel

https://codereview.chromium.org/397543005/diff/1/chrome/browser/chromeos/policy/enterprise_install_attributes.cc File chrome/browser/chromeos/policy/enterprise_install_attributes.cc (right): https://codereview.chromium.org/397543005/diff/1/chrome/browser/chromeos/policy/enterprise_install_attributes.cc#newcode301 chrome/browser/chromeos/policy/enterprise_install_attributes.cc:301: // login_manager/device_policy_service.cc. On 2014/07/16 15:01:57, pastarmovj wrote: > Please ...

6 years, 5 months ago (2014-07-16 15:11:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/397543005/20001

6 years, 5 months ago (2014-07-17 12:01:57 UTC) #5

Message was sent while issue was closed.

Change committed as 283772

Expand Messages | Collapse Messages