Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 397543002: Gallery.app: Don't dispatch an event to update when renaming is not done. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Don't dispatch an event to update when renaming is not done. This is both for efficiency and workaround for crbug.com/393168. BUG=393862 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-15 05:08:46 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-16 03:37:56 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-16 03:38:25 UTC) #3
hirono
On 2014/07/16 03:37:56, yoshiki wrote: > lgtm Thanks!
6 years, 5 months ago (2014-07-16 03:38:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/397543002/1
6 years, 5 months ago (2014-07-16 03:39:24 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:03:41 UTC) #6
Message was sent while issue was closed.
Change committed as 283499

Powered by Google App Engine
This is Rietveld 408576698