Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 397533002: MacViews: Adjust linux_ui guards in process_singleton_posix to match views.gyp (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Adjust linux_ui guards in process_singleton_posix to match views.gyp Currently a linux_ui.h #include/usage in process_singleton_posix is guarded by toolkit_views && !chromeos which (along with _posix) will include Mac. views.gyp has }, { # OS=="linux" and chromeos==0 'sources/': [ ['exclude', 'linux_ui'], ], }], so this just makes them match. BUG=390755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283368

Patch Set 1 #

Patch Set 2 : +views still (for ozone?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/process_singleton_posix.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
Hi sky, please take a look. (This CL might be TBR-worthy, but I thought I'd ...
6 years, 5 months ago (2014-07-15 11:48:49 UTC) #1
sky
I think we should keep the toolkit_views here.
6 years, 5 months ago (2014-07-15 16:41:08 UTC) #2
sky
LGTM
6 years, 5 months ago (2014-07-15 16:41:12 UTC) #3
sky
My rationale for this is that I think ozone may also be defined(OS_LINUX) && !defined(OS_CHROMEOS) ...
6 years, 5 months ago (2014-07-15 16:41:50 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-15 22:10:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/397533002/20001
6 years, 5 months ago (2014-07-15 22:14:20 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:56:15 UTC) #7
Message was sent while issue was closed.
Change committed as 283368

Powered by Google App Engine
This is Rietveld 408576698