Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397493007: Add support for MojoCreateMessagePipeOptions struct to Java bindings (Closed)

Created:
6 years, 5 months ago by qsr
Modified:
6 years, 5 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add support for MojoCreateMessagePipeOptions struct to Java bindings R=viettrungluu@chromium.org BUG=386892 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283515

Patch Set 1 #

Total comments: 4

Patch Set 2 : Follow review #

Patch Set 3 : Rebasing #

Messages

Total messages: 10 (0 generated)
qsr
6 years, 5 months ago (2014-07-15 12:38:42 UTC) #1
viettrungluu
LGTM w/comments fixed. https://codereview.chromium.org/397493007/diff/1/mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java File mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java (right): https://codereview.chromium.org/397493007/diff/1/mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java#newcode17 mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java:17: * Flags for the shared buffer ...
6 years, 5 months ago (2014-07-15 15:50:11 UTC) #2
qsr
https://chromiumcodereview.appspot.com/397493007/diff/1/mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java File mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java (right): https://chromiumcodereview.appspot.com/397493007/diff/1/mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java#newcode17 mojo/public/java/src/org/chromium/mojo/system/MessagePipeHandle.java:17: * Flags for the shared buffer creation operation. On ...
6 years, 5 months ago (2014-07-16 07:28:47 UTC) #3
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 5 months ago (2014-07-16 07:28:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/397493007/20001
6 years, 5 months ago (2014-07-16 07:31:19 UTC) #5
qsr
The CQ bit was unchecked by qsr@chromium.org
6 years, 5 months ago (2014-07-16 08:54:48 UTC) #6
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 5 months ago (2014-07-16 08:55:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/397493007/40001
6 years, 5 months ago (2014-07-16 08:57:29 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 12:42:20 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:29:31 UTC) #10
Message was sent while issue was closed. 
Change committed as 283515

Powered by Google App Engine
This is Rietveld 408576698