mojo/public/cpp/bindings/tests/sample_service_unittest.cc - Issue 397453004: Mojo: Correctly handle large unsigned integer literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 397453004: Mojo: Correctly handle large unsigned integer literals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ULL Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

index dc14ffde9986c9e71171e27a5d5011a08520511f..e5685bdedf9876fcdfdbeb6d2f30528a7b3026b9 100644

--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

@@ -353,11 +353,9 @@ TEST_F(BindingsSampleTest, DefaultValues) {

EXPECT_EQ(1234, defaults->a2);

EXPECT_EQ(34567U, defaults->a3);

EXPECT_EQ(123456, defaults->a4);

- // TODO(vtl): crbug.com/375522

- // EXPECT_EQ(3456789012U, defaults->a5);

+ EXPECT_EQ(3456789012U, defaults->a5);

EXPECT_EQ(111111111111LL, defaults->a6);

- // TODO(vtl): crbug.com/375522

- // EXPECT_EQ(9999999999999999999ULL, defaults->a7);

+ EXPECT_EQ(9999999999999999999ULL, defaults->a7);

EXPECT_EQ(0x12345, defaults->a8);

EXPECT_EQ(-0x12345, defaults->a9);

EXPECT_EQ(1234, defaults->a10);