Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 397453004: Mojo: Correctly handle large unsigned integer literals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add a missing L Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/interfaces/bindings/tests/sample_service.mojom » ('j') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
index dc14ffde9986c9e71171e27a5d5011a08520511f..e5685bdedf9876fcdfdbeb6d2f30528a7b3026b9 100644
--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
@@ -353,11 +353,9 @@ TEST_F(BindingsSampleTest, DefaultValues) {
EXPECT_EQ(1234, defaults->a2);
EXPECT_EQ(34567U, defaults->a3);
EXPECT_EQ(123456, defaults->a4);
- // TODO(vtl): crbug.com/375522
- // EXPECT_EQ(3456789012U, defaults->a5);
+ EXPECT_EQ(3456789012U, defaults->a5);
EXPECT_EQ(111111111111LL, defaults->a6);
- // TODO(vtl): crbug.com/375522
- // EXPECT_EQ(9999999999999999999ULL, defaults->a7);
+ EXPECT_EQ(9999999999999999999ULL, defaults->a7);
EXPECT_EQ(0x12345, defaults->a8);
EXPECT_EQ(-0x12345, defaults->a9);
EXPECT_EQ(1234, defaults->a10);
« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/interfaces/bindings/tests/sample_service.mojom » ('j') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698