[not for review] Add Draw entries to window Performance Timeline

cc/layers/layer_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_IMPL_H_
 #define CC_LAYERS_LAYER_IMPL_H_
 
 #include <set>
 #include <string>
+#include <utility>
+#include <vector>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "cc/animation/animation_delegate.h"
 #include "cc/animation/layer_animation_controller.h"
 #include "cc/animation/layer_animation_value_observer.h"
 #include "cc/animation/layer_animation_value_provider.h"
 #include "cc/base/cc_export.h"
 #include "cc/base/region.h"
@@ skipping 54 matching lines @@
   class ScrollOffsetDelegate {
    public:
     virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) = 0;
     virtual gfx::Vector2dF GetTotalScrollOffset() = 0;
     virtual bool IsExternalFlingActive() const = 0;
   };
 
   typedef LayerImplList RenderSurfaceListType;
   typedef LayerImplList LayerListType;
   typedef RenderSurfaceImpl RenderSurfaceType;
+  typedef std::vector<std::pair<int64_t, gfx::Rect> > DrawFrameRequestRectsType;

[enne (OOO), 2014/07/22 20:44:25]

This could maybe go in LayerTreeHostCommon too with the other DrawTiming types
so you don't have to define it in both Layer and LayerImpl?

bikeshed: You could also maybe call it DrawTimingRequests to match other
DrawTiming* classes?

[Mike B, 2014/07/25 23:09:40]

Done.

 
   enum RenderingContextConstants { NO_RENDERING_CONTEXT = 0 };
 
   static scoped_ptr<LayerImpl> Create(LayerTreeImpl* tree_impl, int id) {
     return make_scoped_ptr(new LayerImpl(tree_impl, id));
   }
 
   virtual ~LayerImpl();
 
   int id() const { return layer_id_; }
@@ skipping 341 matching lines @@
     return non_fast_scrollable_region_;
   }
 
   void SetTouchEventHandlerRegion(const Region& region) {
     touch_event_handler_region_ = region;
   }
   const Region& touch_event_handler_region() const {
     return touch_event_handler_region_;
   }
 
+  void SetDrawFrameRequestRects(const DrawFrameRequestRectsType& rects) {
+    draw_frame_request_rects_ = rects;
+  }
+  const DrawFrameRequestRectsType& draw_frame_request_rects() const {
+    return draw_frame_request_rects_;
+  }
+
   void SetDrawCheckerboardForMissingTiles(bool checkerboard) {
     draw_checkerboard_for_missing_tiles_ = checkerboard;
   }
   bool draw_checkerboard_for_missing_tiles() const {
     return draw_checkerboard_for_missing_tiles_;
   }
 
   InputHandler::ScrollStatus TryScroll(
       const gfx::PointF& screen_space_point,
       InputHandler::ScrollInputType type) const;
@@ skipping 175 matching lines @@
   bool hide_layer_and_subtree_ : 1;
   bool force_render_surface_ : 1;
 
   // Cache transform_'s invertibility.
   bool transform_is_invertible_ : 1;
 
   // Set for the layer that other layers are fixed to.
   bool is_container_for_fixed_position_layers_ : 1;
   Region non_fast_scrollable_region_;
   Region touch_event_handler_region_;
+  DrawFrameRequestRectsType draw_frame_request_rects_;
   SkColor background_color_;
 
   float opacity_;
   SkXfermode::Mode blend_mode_;
   gfx::PointF position_;
   gfx::Transform transform_;
 
   LayerPositionConstraint position_constraint_;
 
   gfx::Vector2dF scroll_delta_;
@@ skipping 50 matching lines @@
   DrawProperties<LayerImpl> draw_properties_;
 
   scoped_refptr<base::debug::ConvertableToTraceFormat> debug_info_;
 
   DISALLOW_COPY_AND_ASSIGN(LayerImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_IMPL_H_