Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 397393002: Use separate-sigma version of SkDropShadowImageFilter::Create (Closed)

Created:
6 years, 5 months ago by Stephen White
Modified:
6 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use separate-sigma version of SkDropShadowImageFilter::Create Use the separate x/y sigma version of SkDropShadowImageFilter's Create() factory, so we can remove the single-param one from Skia. R=danakj@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/output/render_surface_filters.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
Dana: PTAL. Thanks!
6 years, 5 months ago (2014-07-17 23:42:33 UTC) #1
danakj
LGTM
6 years, 5 months ago (2014-07-18 19:01:37 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 5 months ago (2014-07-18 19:35:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/397393002/1
6 years, 5 months ago (2014-07-18 19:37:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:47:22 UTC) #5
Message was sent while issue was closed.
Change committed as 284213

Powered by Google App Engine
This is Rietveld 408576698