Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 397383002: Fix webkitpy scm_unittests so that they pass again. (Closed)

Created:
6 years, 5 months ago by Dirk Pranke
Modified:
6 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix webkitpy scm_unittests so that they pass again. We don't run these by default, so they bitrotted at some point. In particular, it looks like svn 1.7 changed behavior so that if you call svn add foo svn add foo/bar the second call errors out with bar already having been added; in svn 1.6, this was just a warning. This comes up in our code because when adding a file we recursively add the parent directories to ensure the whole path is versioned; we need to change this so that we do not implicitly recurse down when adding a parent directory. Less importantly, it looks like the semantics for git svn clone -T change in Git v2, so the branch names are slightly different and we need to account for the remote branch refs differently as a result. R=eseidel@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178482

Patch Set 1 : patch for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/scm/scm.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 2 chunks +10 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/scm/svn.py View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
6 years, 5 months ago (2014-07-17 22:59:54 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-18 18:52:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/397383002/40001
6 years, 5 months ago (2014-07-18 18:52:56 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 20:00:16 UTC) #4
Message was sent while issue was closed.
Change committed as 178482

Powered by Google App Engine
This is Rietveld 408576698