Introduce centered view and bottom view for home card.

Introduce centered view and bottom view for home card.

We use experimental app-list view for centered layout, and then
use athena's own view for bottom view.

BUG=387227
R=oshima@chromium.org, sadrul@chromium.org, xiyuan@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284275

[Jun Mukai, 2014-07-17 19:57:32]

xiyuan -- I added you for APP_LIST_EXPORT of app_list::TileItemView.

I don't think we should use this in the final version, but
this is probably useful class to see how things will look like.

[xiyuan, 2014-07-17 20:03:01]

ui/app_list/views/tile_item_view.h LGTM

[oshima, 2014-07-17 21:47:33]

https://codereview.chromium.org/397343003/diff/20001/athena/home/bottom_home_...
File athena/home/bottom_home_view.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/bottom_home_...
athena/home/bottom_home_view.cc:20:
set_background(views::Background::CreateSolidBackground(255, 255, 255));
SkColor_WHITE?

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:268:
home_card_view_->bottom_view()->SetVisible(state == VISIBLE_BOTTOM);
It's probably better to have HomeCardView::SetState() and implement this
behavior there?

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:292: SetState(VISIBLE_CENTERED);
don't we have to handle the case where virtual keyboard gets hidden (CENTERED ->
BOTTOM)?

[sadrul, 2014-07-17 22:01:39]

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:188: return kint32max;
Looks like this is deprecated in favour of std::numeric_limits<>

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:193: default:
Use HIDDEN here, so if there's a new state, the compiler tells us to update
this.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:292: SetState(VISIBLE_CENTERED);
Note that when the keyboard pops up for the web-page (instead of for the
home-card), the minimized home-card should be hidden.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:310:
app_list::switches::kEnableExperimentalAppList);
Should this be in athena/main/ instead?

[Jun Mukai, 2014-07-17 22:03:44]

https://codereview.chromium.org/397343003/diff/20001/athena/home/bottom_home_...
File athena/home/bottom_home_view.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/bottom_home_...
athena/home/bottom_home_view.cc:20:
set_background(views::Background::CreateSolidBackground(255, 255, 255));
On 2014/07/17 21:47:33, oshima wrote:
> SkColor_WHITE?

Done.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:268:
home_card_view_->bottom_view()->SetVisible(state == VISIBLE_BOTTOM);
On 2014/07/17 21:47:33, oshima wrote:
> It's probably better to have HomeCardView::SetState() and implement this
> behavior there?

Done.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:292: SetState(VISIBLE_CENTERED);
On 2014/07/17 21:47:33, oshima wrote:
> don't we have to handle the case where virtual keyboard gets hidden (CENTERED
->
> BOTTOM)?

The problem is, we don't know home card appears centered from the beginning, or
temporarily switched from bottom. Added a new state for that.

Introduced another field, |original_state_|, to achieve this.

[oshima, 2014-07-17 22:11:59]

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
athena/home/home_card_impl.cc:289: original_state_ = VISIBLE_BOTTOM;
you can record "previous state" in SetState, and you shouldn't have to do this,
i think.

[Jun Mukai, 2014-07-17 22:12:56]

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:188: return kint32max;
On 2014/07/17 22:01:39, sadrul wrote:
> Looks like this is deprecated in favour of std::numeric_limits<>

Done.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:193: default:
On 2014/07/17 22:01:38, sadrul wrote:
> Use HIDDEN here, so if there's a new state, the compiler tells us to update
> this.

Done.

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:292: SetState(VISIBLE_CENTERED);
On 2014/07/17 22:01:38, sadrul wrote:
> Note that when the keyboard pops up for the web-page (instead of for the
> home-card), the minimized home-card should be hidden.

Done.

[sadrul, 2014-07-18 15:32:37]

LGTM

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:310:
app_list::switches::kEnableExperimentalAppList);
On 2014/07/17 22:01:38, sadrul wrote:
> Should this be in athena/main/ instead?

ping

https://codereview.chromium.org/397343003/diff/60001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/60001/athena/home/home_card_im...
athena/home/home_card_impl.cc:132: Layout();
Does this call to Layout() make sure the widget is resized correctly?

[Jun Mukai, 2014-07-18 20:27:40]

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:310:
app_list::switches::kEnableExperimentalAppList);
On 2014/07/18 15:32:36, sadrul wrote:
> On 2014/07/17 22:01:38, sadrul wrote:
> > Should this be in athena/main/ instead?
> 
> ping

Done.

https://codereview.chromium.org/397343003/diff/60001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/60001/athena/home/home_card_im...
athena/home/home_card_impl.cc:132: Layout();
On 2014/07/18 15:32:36, sadrul wrote:
> Does this call to Layout() make sure the widget is resized correctly?

Right, and it seems this is not necessary.  Moved to Layout() only for the
initialization.
Also, the reason of the BoxLayout was originally I was simply using a
views::View there. Since this is a new class, I can inherit Layout() for my use,
so updated Layout().

[Jun Mukai, 2014-07-18 23:01:48]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:03:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/397343003/80001

[commit-bot: I haz the power, 2014-07-19 01:52:44]

Change committed as 284275

[oshima, 2014-07-19 04:00:13]

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
athena/home/home_card_impl.cc:289: original_state_ = VISIBLE_BOTTOM;
On 2014/07/17 22:11:59, oshima (OOO) until July 21) wrote:
> you can record "previous state" in SetState, and you shouldn't have to do
this,
> i think.

you probably missed this comment.

[Jun Mukai, 2014-07-21 17:30:52]

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/397343003/diff/40001/athena/home/home_card_im...
athena/home/home_card_impl.cc:289: original_state_ = VISIBLE_BOTTOM;
On 2014/07/19 04:00:13, oshima (OOO) until July 21) wrote:
> On 2014/07/17 22:11:59, oshima (OOO) until July 21) wrote:
> > you can record "previous state" in SetState, and you shouldn't have to do
> this,
> > i think.
> 
> you probably missed this comment.

Oops, sorry.
Well, however, I don't think keeping 'previous state' at SetState doesn't work,
because SetState is called in various situation.

For example:
- in MINIMIZED state
- the user press Ctrl-L, state switch to CENTERED
- focus on the search box, the virtual keyboard appears
- close the virtual keyboard
In this situation, we should NOT switch back to MINIMIZED.

original_state_ is, as I added the comment, actually a temporary value only for
the virtual keyboard action, so it needs to be recorded here.