Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 397343002: [Safe Browsing] Use right function to clear preference. (Closed)

Created:
6 years, 5 months ago by Feng Qian
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Safe Browsing] Use right function to clear preference. The code used wrong function to clear preference. BUG=381896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283977

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Feng Qian
6 years, 5 months ago (2014-07-17 19:53:40 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-17 20:04:34 UTC) #2
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 5 months ago (2014-07-17 20:31:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/397343002/20001
6 years, 5 months ago (2014-07-17 20:35:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 00:44:42 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 02:39:58 UTC) #6
Message was sent while issue was closed.
Change committed as 283977

Powered by Google App Engine
This is Rietveld 408576698