Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397333002: Remove updateFirstLetter from RenderListItem::updateMarkerLocation (Closed)

Created:
6 years, 5 months ago by dsinclair
Modified:
6 years, 5 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove updateFirstLetter from RenderListItem::updateMarkerLocation This is split from https://codereview.chromium.org/373503002/. This call was added back in 2007 in https://src.chromium.org/viewvc/blink?revision=21093&view=revision. All of the layout tests continue to pass with the call removed. BUG=391288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/rendering/RenderListItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dsinclair
PTAL. I split this out of the other review so I can use the other ...
6 years, 5 months ago (2014-07-17 18:06:18 UTC) #1
ojan
lgtm
6 years, 5 months ago (2014-07-17 18:30:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/397333002/1
6 years, 5 months ago (2014-07-17 18:31:07 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:42:41 UTC) #4
Message was sent while issue was closed. 
Change committed as 178393

Powered by Google App Engine
This is Rietveld 408576698