LayoutTests/editing/spelling/grammar.html - Issue 39733005: Use asynchronous spellcheck path in layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/spelling/grammar.html

Issue 39733005: Use asynchronous spellcheck path in layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Apply groby's suggestions Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/spelling/design-mode-spellcheck-off-expected.txt ('k') | LayoutTests/editing/spelling/grammar-edit-word.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/spelling/grammar.html

diff --git a/LayoutTests/editing/spelling/grammar.html b/LayoutTests/editing/spelling/grammar.html

index 040a0fe2ce2cc9339d73cf6d519f55837367cbed..109b5c8f67355f2c8381ff3bc7dd58ec6b1bd8d5 100644

--- a/LayoutTests/editing/spelling/grammar.html

+++ b/LayoutTests/editing/spelling/grammar.html

@@ -1,5 +1,6 @@

<html>

<head>

+<script src="../../fast/js/resources/js-test-pre.js"></script>

<style>

.editing {

@@ -11,24 +12,18 @@

-function log(msg) {

- document.getElementById("console").innerHTML += (msg + "\n");

function editingTest() {

if (window.testRunner)

testRunner.dumpAsText();

document.getElementById("root").focus();

document.execCommand("InsertText", false, "I have a issue.");

- if (window.testRunner) {

- if (internals.hasGrammarMarker(document, 7, 1))

- log("PASS");

- else

- log("FAIL");

- document.getElementById("root").style.display = "none";

+ if (window.internals) {

+ shouldBecomeEqual('internals.hasGrammarMarker(document, 7, 1)', 'true', function() {

+ document.getElementById("root").style.display = "none";

+ finishJSTest();

+ });

}

@@ -37,13 +32,20 @@ function editingTest() {

<title>Editing Test</title>

</head>

<body>

-<div>You should see the text 'I have a issue'. 'a' should have a grammar suggestion marking.</div>

-<div contenteditable id="root" class="editing">

-</div>

-<pre id="console"></pre>

+<div contenteditable id="root" class="editing"></div>

+description("This tests whether the grammatically-incorrect phrase "

+ + "'I have a issue' has grammar marker on 'a'.");

+jsTestIsAsync = true;

+if (window.internals) {

+ internals.settings.setUnifiedTextCheckerEnabled(true);

+ internals.settings.setAsynchronousSpellCheckingEnabled(true);

editingTest();

</script>

+<script src="../../fast/js/resources/js-test-post.js"></script>

</body>

</html>