Use asynchronous spellcheck path in layout tests

Use asynchronous spellcheck path in layout tests

As a part of 295722 bug, this change partially deprecates a sync code
path for spellcheck in layout tests in a favour of its asynchronous version
that is planning to be enabled by default.

This commit adapts the following layout tests:
    editing/spelling/design-mode-spellcheck-off.html
    editing/spelling/grammar-edit-word.html
    editing/spelling/grammar.html

The other tests require more changes and I suggest committing them
separately.

BUG=295722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160614

[tony, 2013-10-24 16:39:34]

LGTM, thanks for fixing these tests!

[groby-ooo-7-16, 2013-10-24 16:47:49]

lgtm

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/design-mode-spellcheck-off.html (right):

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/design-mode-spellcheck-off.html:30: var x =
document.body.offsetLeft + 30;
Curious - why the offset changes?

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/grammar-edit-word.html (right):

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/grammar-edit-word.html:38:
internals.settings.setUnifiedTextCheckerEnabled(false);
Is that actually needed? I don't think there's a point in resetting state.

[grzegorz, 2013-10-25 09:41:07]

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/design-mode-spellcheck-off.html (right):

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/design-mode-spellcheck-off.html:30: var x =
document.body.offsetLeft + 30;
On 2013/10/24 16:47:49, groby wrote:
> Curious - why the offset changes?

Chrome's "Inspect Element" shows that description() creates <p> with two spans.
What's is more its margin is 16. Origin description was created by single <p>
and its margin is 8. That's why I had to increase a offset a little to avoid
timeout on body click.

Restored x to 10, and modified y to 17 in patch#2.

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/grammar-edit-word.html (right):

https://codereview.chromium.org/39733005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/grammar-edit-word.html:38:
internals.settings.setUnifiedTextCheckerEnabled(false);
On 2013/10/24 16:47:49, groby wrote:
> Is that actually needed? I don't think there's a point in resetting state.

Done.

[grzegorz, 2013-10-25 18:28:06]

Could you commit it if it's ready to go? Thanks.

[commit-bot: I haz the power, 2013-10-25 18:45:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/39733005/80001

[commit-bot: I haz the power, 2013-10-25 20:06:29]

Change committed as 160614