LevelDBDatabase::Compact compacts db (on disk) w/o requiring reopen.

LevelDBDatabase::Compact compacts db (on disk) w/o requiring reopen.

This change writes (flushes) compacted data to disk resulting in
changes, which would previously only be flushed the next db close/open
cycle, to be written immediately.

BUG=329347
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284313

[jsbell, 2014-07-17 18:33:25]

lgtm

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/i...
File content/browser/indexed_db/indexed_db_browsertest.cc (right):

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_browsertest.cc:645: const int
kTestCompactBytes = 1024 * 10;  // 10kB
Nice!

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/l...
File content/browser/indexed_db/leveldb/leveldb_database.cc (right):

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/l...
content/browser/indexed_db/leveldb/leveldb_database.cc:398:
db_->Write(leveldb::WriteOptions(), NULL);
Please add a comment explaining why this is here.

[cmumford, 2014-07-17 20:51:42]

I added a comment above Write. Note that I also moved it after CompactRange. It
didn't matter if it was before or after (so long as it's flushed before function
returns). I did this only because I felt it was a bit clearer this way.

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/l...
File content/browser/indexed_db/leveldb/leveldb_database.cc (right):

https://codereview.chromium.org/397323003/diff/1/content/browser/indexed_db/l...
content/browser/indexed_db/leveldb/leveldb_database.cc:398:
db_->Write(leveldb::WriteOptions(), NULL);
On 2014/07/17 18:33:24, jsbell wrote:
> Please add a comment explaining why this is here.

Done.

[cmumford, 2014-07-18 18:21:41]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-18 18:22:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/397323003/20001

[commit-bot: I haz the power, 2014-07-18 22:30:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[cmumford, 2014-07-19 01:37:19]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-19 01:38:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/397323003/40001

[commit-bot: I haz the power, 2014-07-19 04:59:17]

Change committed as 284313