Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

Issue 397313003: DevTools: Remove target function from TimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase once more Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
diff --git a/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js b/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
index 8abca8f1ba7d6bb93b5f2804dfc8e7415f1e96ca..968b5e17988f61c0be135136b5e1ce6e71f79864 100644
--- a/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
+++ b/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
@@ -36,14 +36,14 @@ WebInspector.TimelinePaintProfilerView.prototype = {
},
/**
- * @param {!WeakReference.<!WebInspector.Target>} weakTarget
+ * @param {?WebInspector.Target} target
* @param {string} encodedPicture
*/
- setPicture: function(weakTarget, encodedPicture)
+ setPicture: function(target, encodedPicture)
{
this._disposeSnapshot();
this._picture = encodedPicture;
- this._weakTarget = weakTarget;
+ this._target = target;
if (this.isShowing())
this._update();
else
@@ -52,10 +52,9 @@ WebInspector.TimelinePaintProfilerView.prototype = {
_update: function()
{
- var target = this._weakTarget.get();
- if (!target)
+ if (!this._target)
return;
- WebInspector.PaintProfilerSnapshot.load(target, this._picture, onSnapshotLoaded.bind(this));
+ WebInspector.PaintProfilerSnapshot.load(this._target, this._picture, onSnapshotLoaded.bind(this));
/**
* @param {?WebInspector.PaintProfilerSnapshot} snapshot
* @this WebInspector.TimelinePaintProfilerView
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineModelImpl.js ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698