Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2204)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 397313003: DevTools: Remove target function from TimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase once more Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index e4f4b779d32ae0e2cfe55de4516438e6411c918b..d2abe42878a5c6b9c29c2ff342777e7cf5ebeb1d 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -33,14 +33,12 @@
* @implements {WebInspector.FlameChartDataProvider}
* @param {!WebInspector.TracingTimelineModel} model
* @param {!WebInspector.TimelineFrameModelBase} frameModel
- * @param {!WebInspector.Target} target
*/
-WebInspector.TimelineFlameChartDataProvider = function(model, frameModel, target)
+WebInspector.TimelineFlameChartDataProvider = function(model, frameModel)
{
WebInspector.FlameChartDataProvider.call(this);
this._model = model;
this._frameModel = frameModel;
- this._target = target;
this._font = "12px " + WebInspector.fontFamily();
this._linkifier = new WebInspector.Linkifier();
this._entryIndexToTitle = {};
@@ -95,7 +93,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
if (event) {
var name = WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name).title;
// TODO(yurys): support event dividers
- var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier, false, this._target);
+ var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier);
if (event.name === WebInspector.TracingTimelineModel.RecordType.JSFrame && details)
return details.textContent;
return details ? WebInspector.UIString("%s (%s)", name, details.textContent) : name;
@@ -490,7 +488,7 @@ WebInspector.TimelineFlameChart = function(delegate, tracingModel, frameModel)
this.registerRequiredCSS("flameChart.css");
this._delegate = delegate;
this._model = tracingModel;
- this._dataProvider = new WebInspector.TimelineFlameChartDataProvider(tracingModel, frameModel, tracingModel.target())
+ this._dataProvider = new WebInspector.TimelineFlameChartDataProvider(tracingModel, frameModel)
this._mainView = new WebInspector.FlameChart(this._dataProvider, this, true);
this._mainView.show(this.element);
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStarted, this._onRecordingStarted, this);
« no previous file with comments | « Source/devtools/front_end/profiler/ProfilesPanel.js ('k') | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698