DevTools: Remove target function from TimelineModel

DevTools: Remove target function from TimelineModel

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178461

[caseq, 2014-07-17 16:36:44]

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineTracingView.js (right):

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineTracingView.js:139: if (target)
We still need to show some details when the target is absent.

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:620: //FIXME: get it
from this._event
Why not do it now?

[sergeyv, 2014-07-17 17:07:07]

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineTracingView.js (right):

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineTracingView.js:139: if (target)
On 2014/07/17 16:36:44, caseq wrote:
> We still need to show some details when the target is absent.

Done.

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/397313003/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:620: //FIXME: get it
from this._event
On 2014/07/17 16:36:44, caseq wrote:
> Why not do it now?

Because thread has nullable target, and Record has non-nullable. I will fix it
in next patch

[yurys, 2014-07-18 11:22:35]

lgtm

[sergeyv, 2014-07-18 11:24:46]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-07-18 11:25:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397313003/20001

[commit-bot: I haz the power, 2014-07-18 11:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 11:25:48]

Failed to apply patch for
Source/devtools/front_end/timeline/TimelineFlameChart.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/timeline/TimelineFlameChart.js
  Hunk #1 succeeded at 33 with fuzz 1 (offset -411 lines).
  Hunk #2 FAILED at 503.
  Hunk #3 FAILED at 854.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/timeline/TimelineFlameChart.js.rej

Patch:       Source/devtools/front_end/timeline/TimelineFlameChart.js
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js
b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index
bd2a2acd061aa5d2df5f86e1851c25b9c16b137f..a19d09e7b0f00dcce61d42dd402423ccf77bef5c
100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -444,14 +444,12 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
  * @implements {WebInspector.TimelineFlameChart.SelectionProvider}
  * @param {!WebInspector.TracingTimelineModel} model
  * @param {!WebInspector.TimelineFrameModelBase} frameModel
- * @param {!WebInspector.Target} target
  */
-WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model,
frameModel, target)
+WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model,
frameModel)
 {
     WebInspector.FlameChartDataProvider.call(this);
     this._model = model;
     this._frameModel = frameModel;
-    this._target = target;
     this._font = "12px " + WebInspector.fontFamily();
     this._linkifier = new WebInspector.Linkifier();
     this._palette = new WebInspector.TraceViewPalette();
@@ -505,7 +503,7 @@
WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
         if (event) {
             var name =
WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name).title;
             // TODO(yurys): support event dividers
-            var details =
WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event,
this._linkifier, false, this._target);
+            var details =
WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event,
this._linkifier);
             return details ? WebInspector.UIString("%s (%s)", name,
details.textContent) : name;
         }
         var title = this._entryIndexToTitle[entryIndex];
@@ -856,7 +854,7 @@ WebInspector.TimelineFlameChart = function(delegate, model,
tracingModel, frameM
     this._delegate = delegate;
     this._model = model;
     this._dataProvider = tracingModel
-        ? new
WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel,
frameModel, model.target())
+        ? new
WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel,
frameModel)
         : new WebInspector.TimelineFlameChartDataProvider(/** @type
{!WebInspector.TimelineModelImpl} */(model), frameModel, uiUtils);
     this._mainView = new WebInspector.FlameChart(this._dataProvider, this,
true);
     this._mainView.show(this.element);

[sergeyv, 2014-07-18 12:24:33]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-07-18 12:24:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397313003/40001

[commit-bot: I haz the power, 2014-07-18 13:31:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16124)

[sergeyv, 2014-07-18 13:39:06]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-07-18 13:40:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397313003/60001

[commit-bot: I haz the power, 2014-07-18 14:53:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17728)

[commit-bot: I haz the power, 2014-07-18 15:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 15:04:10]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17745)

[sergeyv, 2014-07-18 15:04:55]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-07-18 15:05:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397313003/60001

[commit-bot: I haz the power, 2014-07-18 15:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 15:05:54]

Failed to apply patch for
Source/devtools/front_end/timeline/TimelineFlameChart.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/timeline/TimelineFlameChart.js
  Hunk #1 FAILED at 33.
  Hunk #3 FAILED at 490.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/timeline/TimelineFlameChart.js.rej

Patch:       Source/devtools/front_end/timeline/TimelineFlameChart.js
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js
b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index
6b2a31a52c32be9e203bd778cab35f071dbda1bc..b10abdd38152a35bd958a3307e6565ae2bf2dae4
100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -33,14 +33,12 @@
  * @implements {WebInspector.FlameChartDataProvider}
  * @param {!WebInspector.TracingTimelineModel} model
  * @param {!WebInspector.TimelineFrameModelBase} frameModel
- * @param {!WebInspector.Target} target
  */
-WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model,
frameModel, target)
+WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model,
frameModel)
 {
     WebInspector.FlameChartDataProvider.call(this);
     this._model = model;
     this._frameModel = frameModel;
-    this._target = target;
     this._font = "12px " + WebInspector.fontFamily();
     this._linkifier = new WebInspector.Linkifier();
     this._entryIndexToTitle = {};
@@ -95,7 +93,7 @@
WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
         if (event) {
             var name =
WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name).title;
             // TODO(yurys): support event dividers
-            var details =
WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event,
this._linkifier, false, this._target);
+            var details =
WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event,
this._linkifier);
             if (event.name ===
WebInspector.TracingTimelineModel.RecordType.JSFrame && details)
                 return details.textContent;
             return details ? WebInspector.UIString("%s (%s)", name,
details.textContent) : name;
@@ -490,7 +488,7 @@ WebInspector.TimelineFlameChart = function(delegate,
tracingModel, frameModel)
     this.registerRequiredCSS("flameChart.css");
     this._delegate = delegate;
     this._model = tracingModel;
-    this._dataProvider = new
WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel,
frameModel, tracingModel.target())
+    this._dataProvider = new
WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel,
frameModel)
     this._mainView = new WebInspector.FlameChart(this._dataProvider, this,
true);
     this._mainView.show(this.element);
    
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStarted,
this._onRecordingStarted, this);

[sergeyv, 2014-07-18 16:03:53]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-07-18 16:04:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397313003/80001

[commit-bot: I haz the power, 2014-07-18 17:13:25]

Change committed as 178461