Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 397303005: Add Traversal<>::firstAncestorOrSelf() overload taking a const reference in argument (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Add Traversal<>::firstAncestorOrSelf() overload taking a const reference in argument Add Traversal<>::firstAncestorOrSelf() overload taking a const reference in argument, and returning a const pointer. Make use of this new function in Element::rendererIsFocusable(). R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178504

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/dom/ElementTraversal.h View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 5 months ago (2014-07-18 01:26:57 UTC) #1
adamk
Seems like a small win (and I'm not clear on why you need both Element ...
6 years, 5 months ago (2014-07-18 23:39:14 UTC) #2
Inactive
Sorry, I know this is a small change. I split this out of a bigger ...
6 years, 5 months ago (2014-07-19 00:02:54 UTC) #3
adamk
On 2014/07/19 at 00:02:54, ch.dumez wrote: > Sorry, I know this is a small change. ...
6 years, 5 months ago (2014-07-19 00:04:07 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-19 00:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/397303005/1
6 years, 5 months ago (2014-07-19 00:21:05 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 00:31:09 UTC) #7
Message was sent while issue was closed.
Change committed as 178504

Powered by Google App Engine
This is Rietveld 408576698