Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 397303003: cc: Remove invalidated recycle tree tiles on activation. (Closed)

Created:
6 years, 5 months ago by vmpstr
Modified:
6 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Remove invalidated recycle tree tiles on activation. This patch is the first part of ensuring that recycle tree does not contain any unshared tiles. This is done by ensuring that we invalidate the soon to become recycled tiling while activating. BUG=393802 R=danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283951

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M cc/layers/picture_layer_impl.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vmpstr
PTAL. This kind of undoes/redoes some of the work that you redid/undid. I think we ...
6 years, 5 months ago (2014-07-17 20:18:42 UTC) #1
danakj
LGTM https://codereview.chromium.org/397303003/diff/1/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (right): https://codereview.chromium.org/397303003/diff/1/cc/resources/picture_layer_tiling_set.cc#newcode42 cc/resources/picture_layer_tiling_set.cc:42: tiling->RemoveTilesInRegion(region); just tilings_[i]->Remove...?
6 years, 5 months ago (2014-07-17 20:21:28 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-17 20:21:31 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 5 months ago (2014-07-17 20:21:37 UTC) #4
vmpstr
https://codereview.chromium.org/397303003/diff/1/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (right): https://codereview.chromium.org/397303003/diff/1/cc/resources/picture_layer_tiling_set.cc#newcode42 cc/resources/picture_layer_tiling_set.cc:42: tiling->RemoveTilesInRegion(region); On 2014/07/17 20:21:27, danakj wrote: > just tilings_[i]->Remove...? ...
6 years, 5 months ago (2014-07-17 20:23:23 UTC) #5
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-17 20:23:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/397303003/20001
6 years, 5 months ago (2014-07-17 20:28:15 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:52:32 UTC) #8
Message was sent while issue was closed.
Change committed as 283951

Powered by Google App Engine
This is Rietveld 408576698