DevTools: [Elements] Implement shortcut-based node cut-copy-pasting

Source/core/inspector/InspectorDOMAgent.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 450 matching lines @@
     }
 
     if (node->isPseudoElement()) {
         *errorString = "Cannot edit pseudo elements";
         return 0;
     }
 
     return node;
 }
 
+Node* InspectorDOMAgent::assertEditableChildNode(ErrorString* errorString, Element* parentElement, int nodeId)
+{
+    Node* node = assertEditableNode(errorString, nodeId);
+    if (!node)
+        return 0;
+    if (node->parentNode() != parentElement) {
+        *errorString = "Anchor node must be child of the target element";
+        return 0;
+    }
+    return node;
+}
+
 Element* InspectorDOMAgent::assertEditableElement(ErrorString* errorString, int nodeId)
 {
     Element* element = assertElement(errorString, nodeId);
     if (!element)
         return 0;
 
     if (element->isInShadowTree() && userAgentShadowRoot(element)) {
         *errorString = "Cannot edit elements from user-agent shadow trees";
         return 0;
     }
@@ skipping 804 matching lines @@
         highlightConfig->contentOutline = parseColor(outlineColor);
         m_overlay->highlightNode(frame->deprecatedLocalOwner(), 0 /* eventTarget */, *highlightConfig, false);
     }
 }
 
 void InspectorDOMAgent::hideHighlight(ErrorString*)
 {
     m_overlay->hideHighlight();
 }
 
-void InspectorDOMAgent::moveTo(ErrorString* errorString, int nodeId, int targetElementId, const int* const anchorNodeId, int* newNodeId)
+void InspectorDOMAgent::copyTo(ErrorString* errorString, int nodeId, int targetElementId, const int* const anchorNodeId, const bool* const deep, int* newNodeId)
 {
     Node* node = assertEditableNode(errorString, nodeId);
     if (!node)
         return;
 
     Element* targetElement = assertEditableElement(errorString, targetElementId);
     if (!targetElement)
         return;
 
     Node* anchorNode = 0;
     if (anchorNodeId && *anchorNodeId) {
-        anchorNode = assertEditableNode(errorString, *anchorNodeId);
+        anchorNode = assertEditableChildNode(errorString, targetElement, *anchorNodeId);
         if (!anchorNode)
             return;
-        if (anchorNode->parentNode() != targetElement) {
-            *errorString = "Anchor node must be child of the target element";
-            return;
+    }
+
+    // The clone is deep by default.
+    RefPtrWillBeRawPtr<Node> clonedNode = node->cloneNode(!deep || *deep);
+    if (!clonedNode) {
+        *errorString = "Failed to clone node";
+        return;
+    }
+    if (!m_domEditor->insertBefore(targetElement, clonedNode, anchorNode, errorString))
+        return;
+
+    *newNodeId = pushNodePathToFrontend(clonedNode.get());
+}
+
+void InspectorDOMAgent::moveTo(ErrorString* errorString, int nodeId, int targetElementId, const int* const anchorNodeId, int* newNodeId)
+{
+    Node* node = assertEditableNode(errorString, nodeId);
+    if (!node)
+        return;
+
+    Element* targetElement = assertEditableElement(errorString, targetElementId);
+    if (!targetElement)
+        return;
+
+    Node* anchorNode = 0;
+    if (anchorNodeId && *anchorNodeId) {
+        if (anchorNodeId && *anchorNodeId) {

[aandrey, 2014/07/18 05:30:04]

dup if-

[apavlov, 2014/07/18 09:02:07]

Just to be absolutely sure :) Done.

+            anchorNode = assertEditableChildNode(errorString, targetElement, *anchorNodeId);
+            if (!anchorNode)
+                return;
         }
     }
 
     if (!m_domEditor->insertBefore(targetElement, node, anchorNode, errorString))
         return;
 
     *newNodeId = pushNodePathToFrontend(node);
 }
 
 void InspectorDOMAgent::undo(ErrorString* errorString)
@@ skipping 795 matching lines @@
     if (!m_documentNodeToIdMap->contains(m_document.get())) {
         RefPtr<TypeBuilder::DOM::Node> root;
         getDocument(errorString, root);
         return errorString->isEmpty();
     }
     return true;
 }
 
 } // namespace WebCore