Fix positioning of children of NativeViewHostAura

ui/views/controls/native/native_view_host_aura_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/native/native_view_host_aura.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
@@ skipping 307 matching lines @@
   EXPECT_EQ(NativeViewHostWindowObserver::EVENT_HIDDEN,
             test_observer.events()[2].first);
   EXPECT_EQ(child()->GetNativeView(), test_observer.events()[2].second);
 
   clipping_window()->RemoveObserver(&test_observer);
   child()->GetNativeView()->RemoveObserver(&test_observer);
 
   DestroyHost();
 }
 
+// Regression test for crbug.com/391316
+TEST_F(NativeViewHostAuraTest, PositionPopupsInScreenCoordinates) {
+  CreateHost();
+  toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
+  native_host()->ShowWidget(10, 20, 100, 100);
+  native_host()->InstallClip(35, 45, 50, 50);
+
+  Widget* popup = new views::Widget;
+  Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
+  params.parent = clipping_window();

[sky, 2014/07/22 13:12:27]

parent should be the native view here, right?

[Evan Stade, 2014/07/22 21:45:30]

That won't demonstrate the bug. If I change params.parent to
child()->GetNativeView() it doesn't fail even without the patch.

I don't think I can create an effective unit test in this file for this
regression. RootWindowController is not compiled in views_unittests. The only
reason this test in its current format does fail without the patch is this check
in InitNativeWidget:

    if (parent && parent->type() != ui::wm::WINDOW_TYPE_UNKNOWN)

which of course is not actually what I intended to test. Therefore I have
deleted this test.

[sky, 2014/07/22 21:52:33]

Isn't the real bug that widget->GetNativeView() ended up parented to the
clipping_window? You didn't ask for that, but that's where it ended up, right?
So it seems a test to verify that doesn't happen seems reasonable.

[Evan Stade, 2014/07/22 22:33:22]

That only happened because of code in RootWindowController, which is not
compiled in views_unittests, hence impossible to test from views_unittests.

+  popup->Init(params);
+  popup->Show();
+  popup->SetBounds(gfx::Rect(15, 15, 30, 30));
+
+  EXPECT_EQ(gfx::Rect(15, 15, 30, 30),
+            popup->GetRootView()->GetBoundsInScreen());
+
+  DestroyHost();
+}
+
 }  // namespace views