Fix positioning of children of NativeViewHostAura

ui/views/controls/native/native_view_host_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/native/native_view_host_aura.h"
 
 #include "base/logging.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/focus_client.h"
+#include "ui/aura/layout_manager.h"
 #include "ui/aura/window.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/views/controls/native/native_view_host.h"
 #include "ui/views/view_constants_aura.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
+namespace {
+
+// This layout manager positions children relative to their grandparent's
+// coordinate system.
+class OffsettingLayoutManager : public aura::LayoutManager {

[sky, 2014/07/17 21:46:03]

Seems heavyweight to create this rather than converting on 136.

[Evan Stade, 2014/07/17 22:50:35]

yes, but converting on 136 doesn't work for the autofill popup

+ public:
+  OffsettingLayoutManager() {}
+  virtual ~OffsettingLayoutManager() {}
+
+  virtual void OnWindowResized() OVERRIDE {}
+  virtual void OnWindowAddedToLayout(aura::Window* child) OVERRIDE {}
+  virtual void OnWillRemoveWindowFromLayout(aura::Window* child) OVERRIDE {}
+  virtual void OnWindowRemovedFromLayout(aura::Window* child) OVERRIDE {}
+  virtual void OnChildWindowVisibilityChanged(aura::Window* child,
+                                              bool visible) OVERRIDE {}
+  virtual void SetChildBounds(aura::Window* child,
+                              const gfx::Rect& requested_bounds) OVERRIDE {
+    gfx::Point origin = requested_bounds.origin();
+    gfx::Point this_origin = child->parent()->GetTargetBounds().origin();
+    origin.Offset(-this_origin.x(), -this_origin.y());
+    SetChildBoundsDirect(child, gfx::Rect(origin, requested_bounds.size()));
+  }
+};
+
+}  // namespace
+
 NativeViewHostAura::NativeViewHostAura(NativeViewHost* host)
     : host_(host),
       clipping_window_(NULL) {
   clipping_window_.Init(aura::WINDOW_LAYER_NOT_DRAWN);
+  clipping_window_.SetLayoutManager(new OffsettingLayoutManager());
   clipping_window_.set_owned_by_parent(false);
   clipping_window_.SetName("NativeViewHostAuraClip");
   clipping_window_.layer()->SetMasksToBounds(true);
   clipping_window_.SetProperty(views::kHostViewKey, static_cast<View*>(host_));
 }
 
 NativeViewHostAura::~NativeViewHostAura() {
   if (host_->native_view()) {
     host_->native_view()->RemoveObserver(this);
     host_->native_view()->ClearProperty(views::kHostViewKey);
@@ skipping 66 matching lines @@
   if (host_->fast_resize()) {
     gfx::Point origin(x, y);
     views::View::ConvertPointFromWidget(host_, &origin);
     InstallClip(origin.x(), origin.y(), w, h);
     width = host_->native_view()->bounds().width();
     height = host_->native_view()->bounds().height();
   }
   clipping_window_.SetBounds(clip_rect_ ? *clip_rect_
                                         : gfx::Rect(x, y, w, h));
 
-  gfx::Point clip_offset = clipping_window_.bounds().origin();
-  host_->native_view()->SetBounds(
-      gfx::Rect(x - clip_offset.x(), y - clip_offset.y(), width, height));
+  host_->native_view()->SetBounds(gfx::Rect(x, y, width, height));
   host_->native_view()->Show();
 }
 
 void NativeViewHostAura::HideWidget() {
   host_->native_view()->Hide();
 }
 
 void NativeViewHostAura::SetFocus() {
   aura::Window* window = host_->native_view();
   aura::client::FocusClient* client = aura::client::GetFocusClient(window);
@@ skipping 52 matching lines @@
     } else {
       clipping_window_.RemoveChild(host_->native_view());
     }
     host_->native_view()->SetBounds(clipping_window_.bounds());
   }
   if (clipping_window_.parent())
     clipping_window_.parent()->RemoveChild(&clipping_window_);
 }
 
 }  // namespace views