Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 397263004: Nukes change_ids from view manager (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Nukes change_ids from view manager change_ids are more trouble then they are worth. I'm going to try something else for resolving conflicts. BUG=389339 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -504 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 2 chunks +2 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 11 chunks +6 lines, -37 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 7 chunks +11 lines, -36 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 5 chunks +0 lines, -23 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 7 chunks +3 lines, -24 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 3 chunks +2 lines, -8 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 6 chunks +5 lines, -28 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 2 chunks +1 line, -9 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 19 chunks +29 lines, -73 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 35 chunks +127 lines, -259 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 5 months ago (2014-07-17 15:57:05 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-17 16:18:19 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-17 16:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/397263004/1
6 years, 5 months ago (2014-07-17 16:26:53 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:08:20 UTC) #5
Message was sent while issue was closed.
Change committed as 283830

Powered by Google App Engine
This is Rietveld 408576698