Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397253002: Remove experimental flags that are now required (Closed)

Created:
6 years, 5 months ago by danno
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove experimental flags that are now required R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22461

Patch Set 1 #

Patch Set 2 : Remove comment #

Total comments: 2

Patch Set 3 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1088 lines, -1366 lines) Patch
M src/elements-kind.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements-kind.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/runtime.cc View 3 chunks +1 line, -16 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 3 chunks +358 lines, -380 lines 0 comments Download
M test/mjsunit/array-construct-transition.js View 1 chunk +7 lines, -11 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 2 chunks +146 lines, -167 lines 0 comments Download
M test/mjsunit/array-feedback.js View 2 chunks +145 lines, -168 lines 0 comments Download
M test/mjsunit/array-literal-feedback.js View 2 chunks +40 lines, -63 lines 0 comments Download
M test/mjsunit/array-literal-transitions.js View 2 chunks +93 lines, -110 lines 0 comments Download
M test/mjsunit/array-natives-elements.js View 2 chunks +4 lines, -21 lines 0 comments Download
M test/mjsunit/elements-kind.js View 1 2 5 chunks +149 lines, -184 lines 0 comments Download
M test/mjsunit/elements-kind-depends.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/elements-transition.js View 1 chunk +76 lines, -88 lines 0 comments Download
M test/mjsunit/elements-transition-hoisting.js View 2 chunks +5 lines, -15 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 3 chunks +1 line, -22 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 3 chunks +41 lines, -62 lines 0 comments Download
M test/mjsunit/packed-elements.js View 2 chunks +7 lines, -11 lines 0 comments Download
M test/mjsunit/regress/regress-320532.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-245480.js View 1 2 2 chunks +10 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 5 months ago (2014-07-17 12:27:52 UTC) #1
Michael Starzinger
LGTM. I like it. https://codereview.chromium.org/397253002/diff/20001/test/mjsunit/elements-kind.js File test/mjsunit/elements-kind.js (right): https://codereview.chromium.org/397253002/diff/20001/test/mjsunit/elements-kind.js#newcode199 test/mjsunit/elements-kind.js:199: %NeverOptimizeFunction(construct_smis); nit: Indentation of this ...
6 years, 5 months ago (2014-07-17 12:53:02 UTC) #2
danno
6 years, 5 months ago (2014-07-18 07:17:36 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r22461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698