Pepper: Remove trusted plugin loadable module.

chrome/common/chrome_paths.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_paths.h"
 
 #include "base/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
@@ skipping 41 matching lines @@
 // File name of the internal PDF plugin on different platforms.
 const base::FilePath::CharType kInternalPDFPluginFileName[] =
 #if defined(OS_WIN)
     FILE_PATH_LITERAL("pdf.dll");
 #elif defined(OS_MACOSX)
     FILE_PATH_LITERAL("PDF.plugin");
 #else  // Linux and Chrome OS
     FILE_PATH_LITERAL("libpdf.so");
 #endif
 
-// File name of the internal NaCl plugin on different platforms.
+// Historical file name of the internal NaCl plugin on different platforms.
+// TODO(teravest): See if we can change the strings here to not be an explicit
+// filename. I've left this as the historical value in case disabled-plugin
+// information is stored relative to file path.

[dmichael (off chromium), 2014/07/18 18:08:37]

Hmm, chromoting seems to use a special string:
internal-remoting-viewer

It might be good to follow up to find out if your suspicion is right. If so, I
think I agree with leaving it alone until the plugin is all-the-way gone. Then
we're left with the somewhat strange question of what to do (if anything) for
users who had the plugin disabled. Probably we accept that some users will be
affected, but that they still have enough control since they can separately
disable PNaCl.

[teravest, 2014/07/28 18:40:08]

Done.

 const base::FilePath::CharType kInternalNaClPluginFileName[] =
 #if defined(OS_WIN)
     FILE_PATH_LITERAL("ppGoogleNaClPluginChrome.dll");
 #elif defined(OS_MACOSX)
     // TODO(noelallen) Please verify this extention name is correct.
     FILE_PATH_LITERAL("ppGoogleNaClPluginChrome.plugin");
 #else  // Linux and Chrome OS
     FILE_PATH_LITERAL("libppGoogleNaClPluginChrome.so");
 #endif
 
@@ skipping 523 matching lines @@
 
 void SetInvalidSpecifiedUserDataDir(const base::FilePath& user_data_dir) {
   g_invalid_specified_user_data_dir.Get() = user_data_dir;
 }
 
 const base::FilePath& GetInvalidSpecifiedUserDataDir() {
   return g_invalid_specified_user_data_dir.Get();
 }
 
 }  // namespace chrome