Set ImageCacheSingleAllocationByteLimit to 64MB

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 886 matching lines @@
   // Limit use of the scaled image cache to when deferred image decoding is
   // enabled.
   if (!command_line.HasSwitch(switches::kEnableDeferredImageDecoding) &&
       !is_impl_side_painting_enabled_)
     SkGraphics::SetImageCacheByteLimit(0u);
 
   if (command_line.HasSwitch(switches::kMemoryMetrics)) {
     memory_observer_.reset(new MemoryObserver());
     message_loop()->AddTaskObserver(memory_observer_.get());
   }
+  SkGraphics::SetImageCacheSingleAllocationByteLimit(64 * 1024 * 1024);

[reveman, 2014/07/17 15:33:21]

Can you move "64 * 1024 * 1024" to a constant defined with other constants in
anonymous namespace and add a comment next to it explaining what it's for? I'm
thinking something along the lines:

"Maximum allocation size allowed for image scaling filters that require
pre-scaling. Skia will fallback to a filter that doesn't require pre-scaling if
the default filter would require an allocation that exceeds this limit."

[reveman, 2014/07/17 15:36:06]

nit: move this call up next to the other SkGraphics call to keep these scaled
image cache related adjustments grouped together

[hal.canary, 2014/07/17 16:55:06]

Done.

[hal.canary, 2014/07/17 16:55:07]

Done.

 }
 
 void RenderThreadImpl::RegisterSchemes() {
   // swappedout: pages should not be accessible, and should also
   // be treated as empty documents that can commit synchronously.
   WebString swappedout_scheme(base::ASCIIToUTF16(kSwappedOutScheme));
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(swappedout_scheme);
   WebSecurityPolicy::registerURLSchemeAsEmptyDocument(swappedout_scheme);
 }
 
@@ skipping 691 matching lines @@
   hidden_widget_count_--;
 
   if (!GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden()) {
     return;
   }
 
   ScheduleIdleHandler(kLongIdleHandlerDelayMs);
 }
 
 }  // namespace content