Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397143003: Build-level separation of default CastService implementation. (Closed)

Created:
6 years, 5 months ago by gunsch
Modified:
6 years, 5 months ago
Reviewers:
lcwu1, damienv1, jam
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chromecast-resource-fix
Project:
chromium
Visibility:
Public.

Description

Build-level separation of default CastService implementation. The default implementation (CastServiceSimple) starts up a single page passed in on the command line. R=damienv@chromium.org,lcwu@chromium.org,jam@chromium.org BUG=336640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283812

Patch Set 1 #

Patch Set 2 : copyright capitalization #

Total comments: 4

Patch Set 3 : addressing damienv's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -155 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +6 lines, -1 line 0 comments Download
D chromecast/service/cast_platform_init_stub.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chromecast/service/cast_service.h View 1 2 1 chunk +11 lines, -12 lines 0 comments Download
M chromecast/service/cast_service.cc View 1 2 chunks +3 lines, -106 lines 0 comments Download
A chromecast/service/cast_service_simple.h View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A + chromecast/service/cast_service_simple.cc View 4 chunks +12 lines, -22 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
gunsch
6 years, 5 months ago (2014-07-16 20:47:12 UTC) #1
lcwu1
lgtm
6 years, 5 months ago (2014-07-16 21:09:36 UTC) #2
jam
rubberstamp lgtm
6 years, 5 months ago (2014-07-16 21:30:11 UTC) #3
damienv1
https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service.h File chromecast/service/cast_service.h (right): https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service.h#newcode24 chromecast/service/cast_service.h:24: static CastService* Create(content::BrowserContext* browser_context); nit: Usually static functions come ...
6 years, 5 months ago (2014-07-16 23:59:40 UTC) #4
damienv1
https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service_simple.h File chromecast/service/cast_service_simple.h (right): https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service_simple.h#newcode26 chromecast/service/cast_service_simple.h:26: protected: Should have the usual comment: // CastService implementation.
6 years, 5 months ago (2014-07-17 00:02:39 UTC) #5
gunsch
https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service.h File chromecast/service/cast_service.h (right): https://codereview.chromium.org/397143003/diff/20001/chromecast/service/cast_service.h#newcode24 chromecast/service/cast_service.h:24: static CastService* Create(content::BrowserContext* browser_context); On 2014/07/16 23:59:40, damienv1 wrote: ...
6 years, 5 months ago (2014-07-17 04:33:37 UTC) #6
damienv1
lgtm
6 years, 5 months ago (2014-07-17 15:28:56 UTC) #7
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 5 months ago (2014-07-17 15:33:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/397143003/40001
6 years, 5 months ago (2014-07-17 15:34:20 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 17:56:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 283812

Powered by Google App Engine
This is Rietveld 408576698