Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Side by Side Diff: device/bluetooth/bluetooth_socket_chromeos.h

Issue 397123002: Cleanup: Drop some unnecessary params from the BluetoothSocketNet constructor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « device/bluetooth/bluetooth_device_win.cc ('k') | device/bluetooth/bluetooth_socket_chromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_ 5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_
6 #define DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_ 6 #define DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include <string> 9 #include <string>
10 10
(...skipping 18 matching lines...) Expand all
29 29
30 // The BluetoothSocketChromeOS class implements BluetoothSocket for the 30 // The BluetoothSocketChromeOS class implements BluetoothSocket for the
31 // Chrome OS platform. 31 // Chrome OS platform.
32 class CHROMEOS_EXPORT BluetoothSocketChromeOS 32 class CHROMEOS_EXPORT BluetoothSocketChromeOS
33 : public device::BluetoothSocketNet, 33 : public device::BluetoothSocketNet,
34 public device::BluetoothAdapter::Observer, 34 public device::BluetoothAdapter::Observer,
35 public BluetoothProfileServiceProvider::Delegate { 35 public BluetoothProfileServiceProvider::Delegate {
36 public: 36 public:
37 static scoped_refptr<BluetoothSocketChromeOS> CreateBluetoothSocket( 37 static scoped_refptr<BluetoothSocketChromeOS> CreateBluetoothSocket(
38 scoped_refptr<base::SequencedTaskRunner> ui_task_runner, 38 scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
39 scoped_refptr<device::BluetoothSocketThread> socket_thread, 39 scoped_refptr<device::BluetoothSocketThread> socket_thread);
40 net::NetLog* net_log,
41 const net::NetLog::Source& source);
42 40
43 // Connects this socket to the service on |device| published as UUID |uuid|, 41 // Connects this socket to the service on |device| published as UUID |uuid|,
44 // the underlying protocol and PSM or Channel is obtained through service 42 // the underlying protocol and PSM or Channel is obtained through service
45 // discovery. On a successful connection the socket properties will be updated 43 // discovery. On a successful connection the socket properties will be updated
46 // and |success_callback| called. On failure |error_callback| will be called 44 // and |success_callback| called. On failure |error_callback| will be called
47 // with a message explaining the cause of the failure. 45 // with a message explaining the cause of the failure.
48 virtual void Connect(const BluetoothDeviceChromeOS* device, 46 virtual void Connect(const BluetoothDeviceChromeOS* device,
49 const device::BluetoothUUID& uuid, 47 const device::BluetoothUUID& uuid,
50 const base::Closure& success_callback, 48 const base::Closure& success_callback,
51 const ErrorCompletionCallback& error_callback); 49 const ErrorCompletionCallback& error_callback);
(...skipping 21 matching lines...) Expand all
73 71
74 // Returns the object path of the socket. 72 // Returns the object path of the socket.
75 const dbus::ObjectPath& object_path() const { return object_path_; } 73 const dbus::ObjectPath& object_path() const { return object_path_; }
76 74
77 protected: 75 protected:
78 virtual ~BluetoothSocketChromeOS(); 76 virtual ~BluetoothSocketChromeOS();
79 77
80 private: 78 private:
81 BluetoothSocketChromeOS( 79 BluetoothSocketChromeOS(
82 scoped_refptr<base::SequencedTaskRunner> ui_task_runner, 80 scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
83 scoped_refptr<device::BluetoothSocketThread> socket_thread, 81 scoped_refptr<device::BluetoothSocketThread> socket_thread);
84 net::NetLog* net_log,
85 const net::NetLog::Source& source);
86 82
87 // Register the underlying profile client object with the Bluetooth Daemon. 83 // Register the underlying profile client object with the Bluetooth Daemon.
88 void RegisterProfile(const base::Closure& success_callback, 84 void RegisterProfile(const base::Closure& success_callback,
89 const ErrorCompletionCallback& error_callback); 85 const ErrorCompletionCallback& error_callback);
90 void OnRegisterProfile(const base::Closure& success_callback, 86 void OnRegisterProfile(const base::Closure& success_callback,
91 const ErrorCompletionCallback& error_callback); 87 const ErrorCompletionCallback& error_callback);
92 void OnRegisterProfileError(const ErrorCompletionCallback& error_callback, 88 void OnRegisterProfileError(const ErrorCompletionCallback& error_callback,
93 const std::string& error_name, 89 const std::string& error_name,
94 const std::string& error_message); 90 const std::string& error_message);
95 91
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 bool cancelled; 196 bool cancelled;
201 }; 197 };
202 std::queue<linked_ptr<ConnectionRequest> > connection_request_queue_; 198 std::queue<linked_ptr<ConnectionRequest> > connection_request_queue_;
203 199
204 DISALLOW_COPY_AND_ASSIGN(BluetoothSocketChromeOS); 200 DISALLOW_COPY_AND_ASSIGN(BluetoothSocketChromeOS);
205 }; 201 };
206 202
207 } // namespace chromeos 203 } // namespace chromeos
208 204
209 #endif // DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_ 205 #endif // DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_CHROMEOS_H_
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_device_win.cc ('k') | device/bluetooth/bluetooth_socket_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698