Revert 283572 "Changes to RenderFrameProxy:"

Revert 283572 "Changes to RenderFrameProxy:"

ASan failure (use-after-free) looks like it's due to this change):

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

E.g.:

@@@STEP_LOG_LINE@ReloadEmbedder@SUMMARY: AddressSanitizer: heap-use-after-free content/renderer/render_frame_proxy.cc:168 content::RenderFrameProxy::OnMessageReceived(IPC::Message const&)@@@j

> Changes to RenderFrameProxy:
> 
> - Add accessors: web_frame(), routing_id(), render_view().
> - Remove accessor: render_frame(). Where we do need to touch the
>   RenderFrame, we'll look it up by its routing ID.
> - Small change to the CompositingHelper to use the new getters.
> - Add a map to allow finding a RenderFrameProxy by its associated
>   blink::WebFrame.
> - Introduce a second factory function and differentiate the two
>   factory functions according to the two ways RenderFrameProxies will
>   be created. The first is for when an extant local RenderFrame is
>   being swapped out and replaced with a new RenderFrameProxy. The
>   second is for when a RenderFrameProxy needs to be created without
>   displacing an existing RenderFrame, as shall occur once we mirror
>   the frame tree.
> - This second factory function, which is uncalled at the moment, will
>   create WebRemoteFrames. Also there is stubbed out code in the first
>   factory function to create WebRemoteFrames. This code is in
>   preparation for eliminating the RenderFrame (and its attendant
>   WebLocalFrame) and having instead just a RenderFrameProxy.
> - Add some defensive checks to prepare for when the render frame may
>   not exist, as will happen once the second factory function
>   enters use.
> - Add an Init function so that code can be shared between the two
>   factory functions.
> 
> As an adminstrative note, this patch is a chunk of nasko's 
> larger "use RenderFrameProxyHost" effor (issue 241223002)
> 
> BUG=357747
> TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process
> 
> Review URL: https://codereview.chromium.org/357043006

TBR=nick@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283608

[viettrungluu, 2014-07-17 01:38:21]

Committed patchset #1 manually as r283608 (tree was closed).

[ncarter (slow), 2014-07-17 16:06:42]

Thanks for reverting this, viet-trung.

On Wed, Jul 16, 2014 at 6:38 PM, <viettrungluu@chromium.org> wrote:

> Committed patchset #1 manually as r283608 (tree was closed).
>
> https://codereview.chromium.org/397103006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.