Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 397103003: combine base_unittest.py modules from gm and tools (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, borenet, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

combine base_unittest.py modules from gm and tools general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') Committed: https://skia.googlesource.com/skia/+/66ed8dc4bfd63e4552a213cb17909f9fbbf59abd

Patch Set 1 : everything but pylint cleanup #

Total comments: 1

Patch Set 2 : pylint #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -221 lines) Patch
M gm/rebaseline_server/base_unittest.py View 1 chunk +17 lines, -114 lines 0 comments Download
M gm/rebaseline_server/compare_configs_test.py View 1 2 chunks +10 lines, -7 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures_test.py View 1 4 chunks +15 lines, -11 lines 0 comments Download
M gm/rebaseline_server/compare_to_expectations_test.py View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/rebaseline_server/download_actuals_test.py View 2 chunks +5 lines, -5 lines 0 comments Download
M gm/rebaseline_server/imagediffdb.py View 1 1 chunk +5 lines, -6 lines 0 comments Download
M gm/rebaseline_server/imagediffdb_test.py View 1 4 chunks +5 lines, -5 lines 0 comments Download
M gm/rebaseline_server/imagepair_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/tests/base_unittest.py View 1 3 chunks +92 lines, -35 lines 1 comment Download
A + tools/tests/fix_pythonpath.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/tests/render_pictures_test.py View 1 8 chunks +46 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
https://codereview.chromium.org/397103003/diff/1/gm/rebaseline_server/base_unittest.py File gm/rebaseline_server/base_unittest.py (left): https://codereview.chromium.org/397103003/diff/1/gm/rebaseline_server/base_unittest.py#oldcode28 gm/rebaseline_server/base_unittest.py:28: def setUp(self): Some of these methods were moved into ...
6 years, 5 months ago (2014-07-16 19:54:24 UTC) #1
epoger
Ravi (or someone else if you're interested)- please review at patchset 2. https://codereview.chromium.org/397103003/diff/20001/tools/tests/base_unittest.py File tools/tests/base_unittest.py ...
6 years, 5 months ago (2014-07-16 20:05:45 UTC) #2
rmistry
LGTM
6 years, 5 months ago (2014-07-17 19:02:45 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 5 months ago (2014-07-17 19:41:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/397103003/20001
6 years, 5 months ago (2014-07-17 19:42:15 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:54:21 UTC) #6
Message was sent while issue was closed.
Change committed as 66ed8dc4bfd63e4552a213cb17909f9fbbf59abd

Powered by Google App Engine
This is Rietveld 408576698