Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 397103002: ozone: Port egl_demo on top of PlatformWindow (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

ozone: Port egl_demo on top of PlatformWindow BUG=392280 TEST=built with chromeos==1 use_ozone==1 & ran with egltest platform Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283706

Patch Set 1 #

Patch Set 2 : add check for widget availability #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M ui/ozone/demo/egl_demo.cc View 1 2 2 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
spang
6 years, 5 months ago (2014-07-16 19:52:34 UTC) #1
dnicoara
lgtm https://codereview.chromium.org/397103002/diff/20001/ui/ozone/demo/egl_demo.cc File ui/ozone/demo/egl_demo.cc (right): https://codereview.chromium.org/397103002/diff/20001/ui/ozone/demo/egl_demo.cc#newcode30 ui/ozone/demo/egl_demo.cc:30: CHECK(have_widget_) << "widget not available synchronously"; nit: You ...
6 years, 5 months ago (2014-07-16 19:57:29 UTC) #2
dnicoara
https://codereview.chromium.org/397103002/diff/20001/ui/ozone/demo/egl_demo.cc File ui/ozone/demo/egl_demo.cc (right): https://codereview.chromium.org/397103002/diff/20001/ui/ozone/demo/egl_demo.cc#newcode79 ui/ozone/demo/egl_demo.cc:79: const gfx::Size window_size(800, 600); Oh, and this can probably ...
6 years, 5 months ago (2014-07-16 20:00:00 UTC) #3
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-17 05:15:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/397103002/40001
6 years, 5 months ago (2014-07-17 05:16:45 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 08:15:11 UTC) #6
Message was sent while issue was closed.
Change committed as 283706

Powered by Google App Engine
This is Rietveld 408576698