Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: LayoutTests/inspector/console/console-viewport-selection.html

Issue 397073006: DevTools: [Console] fix corner case in viewport text selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaseline Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-viewport-selection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/console/console-viewport-selection.html
diff --git a/LayoutTests/inspector/console/console-viewport-selection.html b/LayoutTests/inspector/console/console-viewport-selection.html
index 4959cc6b9526e71cd0d5c6da8bfac762cd6db6e3..35ab58270b35be16d87682db79c55f018925679c 100644
--- a/LayoutTests/inspector/console/console-viewport-selection.html
+++ b/LayoutTests/inspector/console/console-viewport-selection.html
@@ -5,8 +5,9 @@
<script>
function populateConsoleWithMessages(count)
{
- for (var i = 0; i < count; ++i)
+ for (var i = 0; i < count - 1; ++i)
console.log("Message #" + i);
+ console.log("hello %cworld", "color: blue");
}
function test()
@@ -146,6 +147,20 @@ function test()
dumpViewportRenderedItems();
next();
},
+
+ function testZeroOffsetSelection(next)
+ {
+ viewport.forceScrollItemToBeLast(messagesCount - 1);
+ var lastMessageElement = viewport.renderedElementAt(messagesCount - 1);
+ // there is a blue-colored "world" span in last message.
+ var blueSpan = lastMessageElement;
+ while (blueSpan.nodeName !== "SPAN" || blueSpan.textContent !== "world")
+ blueSpan = blueSpan.traverseNextNode();
+
+ window.getSelection().setBaseAndExtent(blueSpan, 0, blueSpan, blueSpan.textContent.length);
+ InspectorTest.addResult("Selected text: " + viewport._selectedText());
+ next();
+ },
];
var awaitingMessagesCount = messagesCount;
@@ -156,7 +171,7 @@ function test()
}
InspectorTest.addConsoleSniffer(messageAdded, true);
- InspectorTest.evaluateInConsole(String.sprintf("populateConsoleWithMessages(%d)", messagesCount));
+ InspectorTest.evaluateInPage(String.sprintf("populateConsoleWithMessages(%d)", messagesCount));
function dumpSelectionModelElement(model)
{
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-viewport-selection-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698