Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 397036: Fix find bar scrolling with the page after switching back to tab.... (Closed)

Created:
11 years, 1 month ago by Simon Radford
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Fix find bar scrolling with the page after switching back to tab. We need to do a BrowserView::Layout() (which updates things like the bookmarks bar and the find bar) both in between the TabContents detach/attach AND after the final attach. This way, we toggle the bookmarks bar at the right time, but we still end up setting the find bar properly. R=beng BUG=27960 TEST=Navigate to a page where you can see the vertical scroll bar. Press Ctrl+F to open the find bar. Switch to another tab and then back to the original tab. Scroll down/up the page. The find bar should stay in place, not scroll with the page or disappear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32284

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/views/frame/browser_view.cc View 2 chunks +7 lines, -8 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Simon Radford
11 years, 1 month ago (2009-11-18 02:41:36 UTC) #1
Ben Goodger (Google)
11 years, 1 month ago (2009-11-18 02:45:34 UTC) #2
ok

http://codereview.chromium.org/397036/diff/1/2
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/397036/diff/1/2#newcode1314
Line 1314: // Update all the UI bits.
Note why the ordering here is important.

Powered by Google App Engine
This is Rietveld 408576698