Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1973)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 397023003: Preparing Blink for cross-process frame tree replication (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: dcheng comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index 44df7f6352532d7327994f6f497da6b3419dbdb0..1f285c1c68060bb41cfcf05ff3bea5fea2415346 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -161,12 +161,12 @@ void WebRemoteFrameImpl::setIsRemote(bool)
ASSERT_NOT_REACHED();
}
-void WebRemoteFrameImpl::setRemoteWebLayer(WebLayer* layer)
+void WebRemoteFrameImpl::setRemoteWebLayer(WebLayer* webLayer)
{
if (!frame())
return;
- frame()->setRemotePlatformLayer(layer);
+ frame()->setRemotePlatformLayer(webLayer);
}
void WebRemoteFrameImpl::setPermissionClient(WebPermissionClient*)
@@ -239,8 +239,9 @@ bool WebRemoteFrameImpl::hasVerticalScrollbar() const
WebView* WebRemoteFrameImpl::view() const
{
- ASSERT_NOT_REACHED();
- return 0;
+ if (!frame())
+ return 0;
+ return WebViewImpl::fromPage(frame()->page());
}
void WebRemoteFrameImpl::removeChild(WebFrame* frame)
@@ -251,7 +252,6 @@ void WebRemoteFrameImpl::removeChild(WebFrame* frame)
WebDocument WebRemoteFrameImpl::document() const
{
- ASSERT_NOT_REACHED();
return WebDocument();
}
@@ -510,12 +510,10 @@ bool WebRemoteFrameImpl::isCommandEnabled(const WebString&) const
void WebRemoteFrameImpl::enableContinuousSpellChecking(bool)
{
- ASSERT_NOT_REACHED();
}
bool WebRemoteFrameImpl::isContinuousSpellCheckingEnabled() const
{
- ASSERT_NOT_REACHED();
return false;
}
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698