Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 397023003: Preparing Blink for cross-process frame tree replication (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed extra blank line Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index a3fcf66fb366fb99ddf0d31f76100c9397c57aa3..bd779c46564f9e8d871282ec9db3df9d92ecb9a0 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -365,7 +365,7 @@ void ChromeClientImpl::setResizable(bool value)
bool ChromeClientImpl::shouldReportDetailedMessageForSource(const String& url)
{
- WebLocalFrameImpl* webframe = m_webView->mainFrameImpl();
+ WebLocalFrameImpl* webframe = m_webView->localFrameRootTemporary();
return webframe->client() && webframe->client()->shouldReportDetailedMessageForSource(url);
}
@@ -842,7 +842,12 @@ void ChromeClientImpl::handleKeyboardEventOnTextField(HTMLInputElement& inputEle
void ChromeClientImpl::forwardInputEvent(
WebCore::Frame* frame, WebCore::Event* event)
{
- WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(toLocalFrameTemporary(frame));
+ // FIXME: Input event forwarding to out-of-process frames is broken until
+ // WebRemoteFrameImpl has a WebFrameClient.
+ if (frame->isRemoteFrame())
+ return;
+
+ WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(toLocalFrame(frame));
// This is only called when we have out-of-process iframes, which
// need to forward input events across processes.

Powered by Google App Engine
This is Rietveld 408576698