Preparing Blink for cross-process frame tree replication

Source/web/WebRemoteFrameImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/WebRemoteFrameImpl.h"
 
 #include "core/frame/FrameOwner.h"
 #include "core/frame/RemoteFrame.h"
+#include "core/html/HTMLFrameOwnerElement.h"
 #include "core/page/Page.h"
+#include "core/rendering/RenderLayer.h"
+#include "core/rendering/RenderPart.h"
 #include "public/platform/WebFloatRect.h"
+#include "public/platform/WebLayer.h"

[dcheng, 2014/07/16 21:09:08]

All these includes seem to be unnecessary.

[kenrb, 2014/07/17 14:57:02]

Apparently so. Removed.

 #include "public/platform/WebRect.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebPerformance.h"
 #include "public/web/WebRange.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebViewImpl.h"
 #include <v8/include/v8.h>
 
 using namespace WebCore;
 
@@ skipping 132 matching lines @@
 {
     ASSERT_NOT_REACHED();
     return WebVector<WebIconURL>();
 }
 
 void WebRemoteFrameImpl::setIsRemote(bool)
 {
     ASSERT_NOT_REACHED();
 }
 
-void WebRemoteFrameImpl::setRemoteWebLayer(WebLayer* layer)
+void WebRemoteFrameImpl::setRemoteWebLayer(WebLayer* webLayer)
 {
     if (!frame())
         return;
 
-    frame()->setRemotePlatformLayer(layer);
+    frame()->setRemotePlatformLayer(webLayer);
 }
 
 void WebRemoteFrameImpl::setPermissionClient(WebPermissionClient*)
 {
     ASSERT_NOT_REACHED();
 }
 
 void WebRemoteFrameImpl::setSharedWorkerRepositoryClient(WebSharedWorkerRepositoryClient*)
 {
     ASSERT_NOT_REACHED();
@@ skipping 52 matching lines @@
 }
 
 bool WebRemoteFrameImpl::hasVerticalScrollbar() const
 {
     ASSERT_NOT_REACHED();
     return false;
 }
 
 WebView* WebRemoteFrameImpl::view() const
 {
-    ASSERT_NOT_REACHED();
-    return 0;
+    if (!frame())
+        return 0;
+    return WebViewImpl::fromPage(frame()->page());
 }
 
 void WebRemoteFrameImpl::removeChild(WebFrame* frame)
 {
     WebFrame::removeChild(frame);
     m_ownersForChildren.remove(frame);
 }
 
 WebDocument WebRemoteFrameImpl::document() const
 {
-    ASSERT_NOT_REACHED();
     return WebDocument();
 }
 
 WebPerformance WebRemoteFrameImpl::performance() const
 {
     ASSERT_NOT_REACHED();
     return WebPerformance();
 }
 
 bool WebRemoteFrameImpl::dispatchBeforeUnloadEvent()
@@ skipping 238 matching lines @@
 }
 
 bool WebRemoteFrameImpl::isCommandEnabled(const WebString&) const
 {
     ASSERT_NOT_REACHED();
     return false;
 }
 
 void WebRemoteFrameImpl::enableContinuousSpellChecking(bool)
 {
-    ASSERT_NOT_REACHED();
 }
 
 bool WebRemoteFrameImpl::isContinuousSpellCheckingEnabled() const
 {
-    ASSERT_NOT_REACHED();

[dcheng, 2014/07/16 21:09:08]

We're deleting these because we haven't had time to fix the code that's
incorrectly calling these right?

[kenrb, 2014/07/17 14:57:02]

Yes, except for WebRemoteFrameImpl::view(), which I think correctly should
return a WebViewImpl.

     return false;
 }
 
 void WebRemoteFrameImpl::requestTextChecking(const WebElement&)
 {
     ASSERT_NOT_REACHED();
 }
 
 void WebRemoteFrameImpl::replaceMisspelledRange(const WebString&)
 {
@@ skipping 297 matching lines @@
 
 WebRemoteFrameImpl* WebRemoteFrameImpl::fromFrame(RemoteFrame& frame)
 {
     if (!frame.client())
         return 0;
     return static_cast<RemoteFrameClient*>(frame.client())->webFrame();
 }
 
 } // namespace blink