Preparing Blink for cross-process frame tree replication

Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 286 matching lines @@
         }
     }
 
     setFocusedFrame(frame);
 }
 
 Frame* FocusController::focusedOrMainFrame() const
 {
     if (Frame* frame = focusedFrame())
         return frame;
+
+    for (Frame* frame = m_page->mainFrame()->tree().top(); frame; frame = frame->tree().traverseNext()) {

[dcheng, 2014/07/16 21:09:08]

Can we somehow annotate this as a horrible hack? Perhaps we can collapse this
with the identical loop in WebViewImpl and move it into FrameTree and just call
FrameTree::localRootTemporary in both locations?

[kenrb, 2014/07/17 14:57:02]

I have added a comment. I don't think it is worth the effort to unify them
because both should be short-lived, and will be removed at different times.

+        if (frame->isLocalRoot())
+            return frame;
+    }
+
     return m_page->mainFrame();
 }
 
 void FocusController::setFocused(bool focused)
 {
     if (isFocused() == focused)
         return;
 
     m_isFocused = focused;
 
@@ skipping 406 matching lines @@
     if (m_isActive == active)
         return;
 
     m_isActive = active;
 
     if (m_page->mainFrame()->isLocalFrame()) {
         if (FrameView* view = m_page->deprecatedLocalMainFrame()->view())
             view->updateControlTints();
     }
 
-    toLocalFrame(focusedOrMainFrame())->selection().pageActivationChanged();
+    Frame* frame = focusedOrMainFrame();
+    if (frame->isLocalFrame())
+        toLocalFrame(frame)->selection().pageActivationChanged();
 }
 
 static void updateFocusCandidateIfNeeded(FocusType type, const FocusCandidate& current, FocusCandidate& candidate, FocusCandidate& closest)
 {
     ASSERT(candidate.visibleNode->isElementNode());
     ASSERT(candidate.visibleNode->renderer());
 
     // Ignore iframes that don't have a src attribute
     if (frameOwnerElement(candidate) && (!frameOwnerElement(candidate)->contentFrame() || candidate.rect.isEmpty()))
         return;
@@ skipping 176 matching lines @@
         startingRect = nodeRectInAbsoluteCoordinates(container, true /* ignore border */);
         container = scrollableEnclosingBoxOrParentFrameForNodeInDirection(type, container);
         if (container && container->isDocumentNode())
             toDocument(container)->updateLayoutIgnorePendingStylesheets();
     } while (!consumed && container);
 
     return consumed;
 }
 
 } // namespace WebCore