Issue 396993004: Go to slow path when JSON.stringifying the global proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396993004: Go to slow path when JSON.stringifying the global proxy. (Closed)

Created:
6 years, 5 months ago by Yang

Modified:
6 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Go to slow path when JSON.stringifying the global proxy. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22440

Patch Set 2 : addressed comment #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	src/json-stringifier.h	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

LGTM with nit https://codereview.chromium.org/396993004/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/396993004/diff/1/src/json-stringifier.h#newcode634 src/json-stringifier.h:634: ASSERT(!object->IsJSGlobalProxy() && !object->IsJSGlobalObject()); Maybe test IsGlobalObject() ...

6 years, 5 months ago (2014-07-16 16:08:03 UTC) #2

Yang

https://codereview.chromium.org/396993004/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/396993004/diff/1/src/json-stringifier.h#newcode634 src/json-stringifier.h:634: ASSERT(!object->IsJSGlobalProxy() && !object->IsJSGlobalObject()); On 2014/07/16 16:08:03, Toon Verwaest wrote: ...

6 years, 5 months ago (2014-07-17 08:35:18 UTC) #3

Yang

6 years, 5 months ago (2014-07-17 08:35:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22440 (presubmit successful).

Expand Messages | Collapse Messages

Issue 396993004: Go to slow path when JSON.stringifying the global proxy. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages